Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754916AbbHNKCp (ORCPT ); Fri, 14 Aug 2015 06:02:45 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:32809 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754757AbbHNKCn (ORCPT ); Fri, 14 Aug 2015 06:02:43 -0400 MIME-Version: 1.0 In-Reply-To: <1439545369-18022-3-git-send-email-adrianremonda@gmail.com> References: <1439545369-18022-1-git-send-email-adrianremonda@gmail.com> <1439545369-18022-3-git-send-email-adrianremonda@gmail.com> Date: Fri, 14 Aug 2015 12:02:42 +0200 Message-ID: Subject: Re: [PATCHv6 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings From: Frans Klaver To: Adrian Remonda Cc: Greg KH , christian.gromm@microchip.com, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 37 On Fri, Aug 14, 2015 at 11:42 AM, Adrian Remonda wrote: > This patch fixes the warning generated by sparse: "Using plain integer > as NULL pointer" by replacing the offending 0 with NULL. > > Signed-off-by: Adrian Remonda > --- > v6: styling. Change the NULL test to comply with the Kernel coding style Your commit message no longer fits the actual change... > drivers/staging/most/mostcore/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c > index fa9c19b65a5c..7bb16db42893 100644 > --- a/drivers/staging/most/mostcore/core.c > +++ b/drivers/staging/most/mostcore/core.c > @@ -982,7 +982,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj, > if (ret) > return ret; > > - if (mdev_devnod == 0 || *mdev_devnod == 0) { > + if (!mdev_devnod || *mdev_devnod == 0) { > snprintf(devnod_buf, sizeof(devnod_buf), "%s-%s", mdev, mdev_ch); > mdev_devnod = devnod_buf; > } > -- Thanks, Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/