Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755350AbbHNNVx (ORCPT ); Fri, 14 Aug 2015 09:21:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50839 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbbHNNVv (ORCPT ); Fri, 14 Aug 2015 09:21:51 -0400 From: Lubomir Rintel To: Greg Kroah-Hartman Cc: Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel@vger.kernel.org, "Eric W. Biederman" , linux-fsdevel@vger.kernel.org, Lubomir Rintel Subject: [PATCH] kdbus: create /sys/fs/kdbus with sysfs_create_mount_point() Date: Fri, 14 Aug 2015 15:21:43 +0200 Message-Id: <1439558503-1749-1-git-send-email-lkundrak@v3.sk> In-Reply-To: <877fozw4bo.fsf@x220.int.ebiederm.org> References: <877fozw4bo.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 60 Since 0cbee99269 user-namespace pull, if a kdbusfs is mounted on a location that's not created with sysfs_create_mount_point the user namespaces are not allowed to mount their sysfs instances. Signed-off-by: Lubomir Rintel --- Applies on top of char-misc/kdbus a36324913. ipc/kdbus/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/ipc/kdbus/main.c b/ipc/kdbus/main.c index 1ad4dc8..c2117ea 100644 --- a/ipc/kdbus/main.c +++ b/ipc/kdbus/main.c @@ -75,16 +75,13 @@ * 'ยป struct kdbus_ep *ep (owned) */ -/* kdbus mount-point /sys/fs/kdbus */ -static struct kobject *kdbus_dir; - static int __init kdbus_init(void) { int ret; - kdbus_dir = kobject_create_and_add(KBUILD_MODNAME, fs_kobj); - if (!kdbus_dir) - return -ENOMEM; + ret = sysfs_create_mount_point(fs_kobj, KBUILD_MODNAME); + if (ret) + return ret; ret = kdbus_fs_init(); if (ret < 0) { @@ -96,14 +93,14 @@ static int __init kdbus_init(void) return 0; exit_dir: - kobject_put(kdbus_dir); + sysfs_remove_mount_point(fs_kobj, KBUILD_MODNAME); return ret; } static void __exit kdbus_exit(void) { kdbus_fs_exit(); - kobject_put(kdbus_dir); + sysfs_remove_mount_point(fs_kobj, KBUILD_MODNAME); ida_destroy(&kdbus_node_ida); } -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/