Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbbHOCMF (ORCPT ); Fri, 14 Aug 2015 22:12:05 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44258 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbbHOCL4 (ORCPT ); Fri, 14 Aug 2015 22:11:56 -0400 Date: Fri, 14 Aug 2015 17:36:25 +0100 From: Mark Brown To: Markus Pargmann Cc: Jonathan Cameron , Srinivas Pandruvada , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Message-ID: <20150814163625.GY10748@sirena.org.uk> References: <1439374365-20623-1-git-send-email-mpa@pengutronix.de> <1439374365-20623-15-git-send-email-mpa@pengutronix.de> <20150812115759.GB10748@sirena.org.uk> <20150812124706.GI19600@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rVbcdceMkFY6fDyG" Content-Disposition: inline In-Reply-To: <20150812124706.GI19600@pengutronix.de> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 70.98.210.100 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 14/20] regmap: Add raw_write/read checks for max_raw_write/read sizes X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 44 --rVbcdceMkFY6fDyG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 12, 2015 at 02:47:06PM +0200, Markus Pargmann wrote: > On Wed, Aug 12, 2015 at 12:57:59PM +0100, Mark Brown wrote: > > On Wed, Aug 12, 2015 at 12:12:39PM +0200, Markus Pargmann wrote: > > > Check in regmap_raw_read() and regmap_raw_write() for correct maximum > > > sizes of the operations. Return -E2BIG if this size is not supported > > > because it is too big. > > Why not just split the transaction up like your other changes did? > My intention was to keep these raw functions as close to the actual > hardware as possible also reporting proper error values. For > transactions that are split up you could still use the bulk functions. That's not what we do otherwise, and not what you yourself have done for some of the other changes in the series like those around multi write. --rVbcdceMkFY6fDyG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVzhkIAAoJECTWi3JdVIfQY8UH/jMKMSuTZlYL+L1l640cb04+ x1xq2+Q64bNAHnkdFOCx3mQw2ZZJUxBVg42Ox5pMQqbq24v6RWVkcktO2rbwkomn 80z3fDJE+K/hyAqpr5TiZZXSnne0qm9ESdluHm2YcVVosFO8jXR6G73QiuH9lIdn HCIYNn6BaG88jbp/suOWD6le0AG5Egb9ZQ48IPN+wyVGug2P1nQIFl4T1KKitT24 RWMCF6zjCuxO4UFyRn0FWPIl9eq8/qLr2J7lfXEnxmt31vIUodyMz8csaBaESxjM PZgbMRWM6Zzb8pPUngCfjoOtnQtQEHFnnqgueyigTu0XSdOV77mvJTeYdQ/Jja0= =VJiO -----END PGP SIGNATURE----- --rVbcdceMkFY6fDyG-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/