Date: Fri, 14 Aug 2015 17:40:00 +0100
From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>, kernel@pengutronix.de,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        linux-arm-kernel@lists.infradead.org
Message-ID: <20150814164000.GZ10748@sirena.org.uk>
References: <1439374365-20623-1-git-send-email-mpa@pengutronix.de>
 <1439374365-20623-10-git-send-email-mpa@pengutronix.de>
 <20150812112035.GX10748@sirena.org.uk>
 <20150812122011.GE19600@pengutronix.de>
 <20150812123406.GG10748@sirena.org.uk>
 <20150812130518.GM19600@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="1RuPiyELjUd36Oro"
Content-Disposition: inline
In-Reply-To: <20150812130518.GM19600@pengutronix.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without
 write()
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2462
Lines: 55


--1RuPiyELjUd36Oro
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 12, 2015 at 03:05:18PM +0200, Markus Pargmann wrote:
> On Wed, Aug 12, 2015 at 01:34:06PM +0100, Mark Brown wrote:

> > > Yes right. On the other hand if bus->read() and bus->write() was not set
> > > in the init method (before this patch series) no formatting functions at
> > > all were assigned. So it was always ignored for bus->reg_read() and
> > > bus->reg_write()?!

> > I'm not sure what the "it" you're talking about here is, sorry.  There
> > are unsupported features in the API especially for cases that don't make
> > a huge amount of sense, the error handling isn't always complete.  It
> > sounds like you might be trying to support one of these nonsensical
> > cases - it's not obvious what raw I/O on a device where we don't know
> > the raw format of the device should mean or how anything could sensibly
> > use that.

> The bus and the regmap user are separate. So as a regmap user, I am not
> able to know if the bus the device is connected to actually supports raw
> reads/writes. At least it should not fail with a null pointer when using

You should generally have a pretty good idea simply by knowing which
device you're working with - unless you're writing generic code you know
which device you're working with and what it's capabilities are.  A
driver that doesn't know these things should never be trying to do raw
I/O, and a driver that is doing raw I/O clearly depends on having the
ability to get a bytestream to and from the device since that's what raw
I/O does.

--1RuPiyELjUd36Oro
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVzhnfAAoJECTWi3JdVIfQ4hkH/Rs/IXiiK8Ih2ZA6vzaipvCo
PI/3N5LV8lB9Jb4TB5EJsC+af5sDMuqfwEboiiTBpBj68Kan5U+46uQ/HqWlvu4O
/Z/8dEaIBlFVFhOpVfXE7u/YSsC8FT/Zfy0YRyTMFUG3UZQd7BxEyZb9vDxuPjFf
Jey1pujo9x2gs+v53C9NEvdjwphyv4ahfkAnL6awUkuKsJz3gV9Xu1AWo+pnjlyH
ie1LnQweXRwe/TYIH/nW1V/pY0ZR6LhuPfujILSfxFfZkANC5kuSbUZs0+rZqXcG
4F5Ly3acpjCyCfUKWil0xN9jRapkcEOaO/U4pCMqKLIUAASm0vSroi3qSPd/Mfs=
=xPKo
-----END PGP SIGNATURE-----

--1RuPiyELjUd36Oro--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/