Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755734AbbHNRZc (ORCPT ); Fri, 14 Aug 2015 13:25:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50712 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755693AbbHNRZ3 (ORCPT ); Fri, 14 Aug 2015 13:25:29 -0400 Subject: Patch "md/bitmap: return an error when bitmap superblock is corrupt." has been added to the 3.14-stable tree To: neilb@suse.com, gqjiang@suse.com, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, rgoldwyn@suse.com Cc: , From: Date: Fri, 14 Aug 2015 10:25:28 -0700 In-Reply-To: <20150814170421.60d40eb0@noble> Message-ID: <1439573128240167@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2656 Lines: 71 This is a note to let you know that I've just added the patch titled md/bitmap: return an error when bitmap superblock is corrupt. to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: md-bitmap-return-an-error-when-bitmap-superblock-is-corrupt.patch and it can be found in the queue-3.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From neilb@suse.com Fri Aug 14 10:23:56 2015 From: NeilBrown Date: Fri, 14 Aug 2015 17:04:21 +1000 Subject: md/bitmap: return an error when bitmap superblock is corrupt. To: stable@vger.kernel.org, linux-raid Cc: GuoQing Jiang , Goldwyn Rodrigues , lkml Message-ID: <20150814170421.60d40eb0@noble> From: NeilBrown commit b97e92574c0bf335db1cd2ec491d8ff5cd5d0b49 upstream Use separate bitmaps for each nodes in the cluster bitmap_read_sb() validates the bitmap superblock that it reads in. If it finds an inconsistency like a bad magic number or out-of-range version number, it prints an error and returns, but it incorrectly returns zero, so the array is still assembled with the (invalid) bitmap. This means it could try to use a bitmap with a new version number which it therefore does not understand. This bug was introduced in 3.5 and fix as part of a larger patch in 4.1. So the patch is suitable for any -stable kernel in that range. Fixes: 27581e5ae01f ("md/bitmap: centralise allocation of bitmap file pages.") Signed-off-by: NeilBrown Reported-by: GuoQing Jiang --- drivers/md/bitmap.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -564,6 +564,8 @@ static int bitmap_read_sb(struct bitmap if (err) return err; + err = -EINVAL; + sb = kmap_atomic(sb_page); chunksize = le32_to_cpu(sb->chunksize); Patches currently in stable-queue which might be from neilb@suse.com are queue-3.14/md-raid1-extend-spinlock-to-protect-raid1_end_read_request-against-inconsistencies.patch queue-3.14/md-bitmap-return-an-error-when-bitmap-superblock-is-corrupt.patch queue-3.14/md-use-kzalloc-when-bitmap-is-disabled.patch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/