Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbbHOCLt (ORCPT ); Fri, 14 Aug 2015 22:11:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44211 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbHOCLq (ORCPT ); Fri, 14 Aug 2015 22:11:46 -0400 Date: Fri, 14 Aug 2015 18:56:16 +0100 From: Mark Brown To: Henry Chen Cc: Daniel Kurtz , Matthias Brugger , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Eddie Huang =?utf-8?B?KOm7g+aZuuWCkSk=?= , Kevin Hilman Message-ID: <20150814175616.GA10748@sirena.org.uk> References: <1437396110-5192-1-git-send-email-henryc.chen@mediatek.com> <20150720150254.GC11162@sirena.org.uk> <1437458845.30329.51.camel@mtksdaap41> <1439479505.32674.43.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fIj/D6Y6BN1okdX1" Content-Disposition: inline In-Reply-To: <1439479505.32674.43.camel@mtksdaap41> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 70.98.210.100 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: Add function check before called format_val X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1992 Lines: 47 --fIj/D6Y6BN1okdX1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 13, 2015 at 11:25:05PM +0800, Henry Chen wrote: > On Wed, 2015-08-12 at 22:20 +0800, Daniel Kurtz wrote: > > Making mtk_pmic-wrap into a regmap_bus makes a bit of sense > > architecturally, too, since it is essentially just a bus for accessing > > the registers of an off-chip PMIC. The CPU sees a platform bus, but > > the registers of the remote PMIC are accessed over a dedicated SPI > > bus. > Sorry, I'm afraid that I cannot do this right on init as you said last > time. What do you think about regmap_bus, can you accept that way? I don't have enough context from the above to understand what's going on, sorry. Implementing a bus for something that isn't actually a Linux bus doesn't seem like the best idea though and in general what I'm seeing of the discussion sounds like you're hacking around in driver code to bodge around problems that are being seen rather than really addressing things, the code I can see certainly looks like it just wants to be implementing read and write operations for a single MFD. --fIj/D6Y6BN1okdX1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVziu8AAoJECTWi3JdVIfQnhkH/2Aab0NcG77t8omUTKUSJTH9 SE3be/2VL5nSmYgQPm0uj3M/LZ6S/qLdIicMHKvD9ofOPIQMpKuWsjSwo98IAqF2 rX5lVwFL3XXR/JCFvK9awrbh0xpz0nf83jpHTw+zgrC9vLJH0WDbFeIPN/WI8Pta ocBLwVk7aUkR4sg0ttyMMyNh7hhcaU2ay9lVOSTmDdaaI2nWfX6a4UUK8m6c+j9b u112llNvi1IU/FXkMz+kywnbrt35+pFSNih2/ZKCI5mqsADR9BvAS1x9eeV3M7p3 XhMuuV+AUa7/t7WHk96kLqBmOLsErkO/58Whz5d5GJDkV0ckaSmNFbNfQTZsGLk= =bbjf -----END PGP SIGNATURE----- --fIj/D6Y6BN1okdX1-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/