Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753871AbbHNTIa (ORCPT ); Fri, 14 Aug 2015 15:08:30 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:33134 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbbHNTI3 (ORCPT ); Fri, 14 Aug 2015 15:08:29 -0400 From: Alexander Kuleshov To: Tomas Winkler Cc: linux-kernel@vger.kernel.org, Alexander Kuleshov Subject: [PATCH] mm/memblock: validate the creation of debugfs files Date: Sat, 15 Aug 2015 01:08:11 +0600 Message-Id: <1439579292-15458-1-git-send-email-kuleshovmail@gmail.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 55 Signed-off-by: Alexander Kuleshov --- mm/memblock.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 87108e7..c09e911 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1692,16 +1692,34 @@ static const struct file_operations memblock_debug_fops = { static int __init memblock_init_debugfs(void) { + struct dentry *f; struct dentry *root = debugfs_create_dir("memblock", NULL); if (!root) return -ENXIO; - debugfs_create_file("memory", S_IRUGO, root, &memblock.memory, &memblock_debug_fops); - debugfs_create_file("reserved", S_IRUGO, root, &memblock.reserved, &memblock_debug_fops); + + f = debugfs_create_file("memory", S_IRUGO, root, &memblock.memory, &memblock_debug_fops); + if (!f) { + pr_err("Failed to create memory debugfs file\n"); + goto err_out; + } + + f = debugfs_create_file("reserved", S_IRUGO, root, &memblock.reserved, &memblock_debug_fops); + if (!f) { + pr_err("Failed to create reserved debugfs file\n"); + goto err_out; + } + #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP - debugfs_create_file("physmem", S_IRUGO, root, &memblock.physmem, &memblock_debug_fops); + f = debugfs_create_file("physmem", S_IRUGO, root, &memblock.physmem, &memblock_debug_fops); + if (!f) { + pr_err("Failed to create physmem debugfs file\n"); + goto err_out; + } #endif return 0; +err_out: + return -ENOMEM; } __initcall(memblock_init_debugfs); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/