Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbbHOAXO (ORCPT ); Fri, 14 Aug 2015 20:23:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33624 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbbHOAXM (ORCPT ); Fri, 14 Aug 2015 20:23:12 -0400 Date: Fri, 14 Aug 2015 17:23:12 -0700 From: Greg Kroah-Hartman To: Eduardo Valentin Cc: Jiri Slaby , Fabio Estevam , Sascha Hauer , Linux PM , linux-serial@vger.kernel.org, LKML Subject: Re: [PATCHv3 6/8] serial: imx: add runtime pm support Message-ID: <20150815002312.GA26089@kroah.com> References: <1439313687-28502-1-git-send-email-edubezval@gmail.com> <1439313687-28502-7-git-send-email-edubezval@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439313687-28502-7-git-send-email-edubezval@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2561 Lines: 65 On Tue, Aug 11, 2015 at 10:21:25AM -0700, Eduardo Valentin wrote: > This change introduces the runtime pm support on imx serial > driver. The objective is to be able to idle the uart > port whenever it is not in use while still being able > to wake it up when needed. The key changes in this patch are: > 1. Move the clock handling to runtime pm. Both, ipg and per, > are now handled in the suspend and resume callbacks. Only > enabling and disabling the clocks are handled in runtime > suspend and resume, so we are able to use runtime pm > in IRQ context. > 2. Clocks are prepared in probe and unprepared in remove, > so we do not need to prepare (may sleep) in runtime pm. > 3. We mark the device activity based on uart and console > callbacks. Whenever the device is needed and we want to > access registers, we runtime_pm_get and then mark its > last usage when we are done. This is done also across > IRQs and DMA callbacks. > 4. We reuse the infrastructure in place for suspend and > resume, so we do not need to redo wakeup configuration, > or context save and restore. > > After this change, the clocks are still sane, in the sense > of having balanced clock prepare and enable. > > Cc: Fabio Estevam > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > drivers/tty/serial/imx.c | 224 +++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 178 insertions(+), 46 deletions(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 50abb60..9447a55 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -39,6 +39,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #include > #include > @@ -219,6 +222,7 @@ struct imx_port { > unsigned int saved_reg[10]; > bool context_saved; > > + struct device *dev; Do you really need this pointer? Can't you get it from the platform device that you have access to that sport is the data? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/