Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbbHOBts (ORCPT ); Fri, 14 Aug 2015 21:49:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35055 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbbHOBtr (ORCPT ); Fri, 14 Aug 2015 21:49:47 -0400 Date: Fri, 14 Aug 2015 18:49:46 -0700 From: Greg Kroah-Hartman To: Maxime Lorrillere Cc: Sudip Mukherjee , Oleg Drokin , Andreas Dilger , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Message-ID: <20150815014946.GA19664@kroah.com> References: <1439373065-11020-1-git-send-email-maxime.lorrillere@gmail.com> <20150814055834.GA421@sudip-pc> <20150814140031.GA31688@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150814140031.GA31688@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 24 On Fri, Aug 14, 2015 at 04:00:31PM +0200, Maxime Lorrillere wrote: > On vendredi 14 ao?t 2015 ? 11:28:35 (+0530), Sudip Mukherjee wrote > > On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote: > > > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c: > > > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static? > > > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static? > > > > > > Signed-off-by: Maxime Lorrillere > > > --- > > You have not build tested. > > > > WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! > > WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! > > Sorry, I've only rebuild lustre separately. > > Patch 2/2 builds fine, should I submit it separately ? Yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/