Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbbHOEyE (ORCPT ); Sat, 15 Aug 2015 00:54:04 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:42695 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbbHOEyB (ORCPT ); Sat, 15 Aug 2015 00:54:01 -0400 Message-ID: <55CEC5E8.6090203@wwwdotorg.org> Date: Fri, 14 Aug 2015 22:54:00 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Eric Anholt CC: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org Subject: Re: [PATCH 7/7] ARM: bcm2835: Add VC4 to the device tree. References: <1439427380-2436-1-git-send-email-eric@anholt.net> <1439427380-2436-8-git-send-email-eric@anholt.net> In-Reply-To: <1439427380-2436-8-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 26 On 08/12/2015 06:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt Patch description? > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > arm-pmu { > compatible = "arm,arm1176-pmu"; > }; > + > + hdmi: brcm,vc4-hdmi@7e902000 { It'd be nice to keep all the DT nodes with a reg property together, and sorted in reg order. As before, I think any DT node for a HW block that may-or-may-not-be used based on board connectivity/features should be disabled in the SoC .dtsi file, and enabled in the board's DT file if the feature is useful for that board. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/