Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbbHOFK1 (ORCPT ); Sat, 15 Aug 2015 01:10:27 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35774 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbbHOFKZ (ORCPT ); Sat, 15 Aug 2015 01:10:25 -0400 Subject: Re: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl To: Chase Metzger , Greg Kroah-Hartman , Alan Stern , Petr Mladek , Peter Chen , Felipe Balbi , Matthew Garrett , Robert Schlabbach , Zhuang Jin Can , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1439613714-14835-1-git-send-email-chasemetzger15@gmail.com> From: Lars Melin Message-ID: <55CEC9B2.6040804@gmail.com> Date: Sat, 15 Aug 2015 12:10:10 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1439613714-14835-1-git-send-email-chasemetzger15@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 53 On 2015-08-15 11:41, Chase Metzger wrote: > Removed some checkpatch.pl warnings saying there was an unwanted space between > function names and their arguments. > > Signed-off-by: Chase Metzger > --- > drivers/usb/core/hub.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 38cb6d3..b9cab51 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -4218,7 +4218,7 @@ static int hub_enable_device(struct usb_device *udev) > * but it is still necessary to lock the port. > */ > static int > -hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1, > +hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, > int retry_counter) > { > struct usb_device *hdev = hub->hdev; > @@ -4522,7 +4522,7 @@ fail: > } > > static void > -check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1) > +check_highspeed(struct usb_hub *hub, struct usb_device *udev, int port1) > { > struct usb_qualifier_descriptor *qual; > int status; > @@ -4530,11 +4530,11 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1) > if (udev->quirks & USB_QUIRK_DEVICE_QUALIFIER) > return; > > - qual = kmalloc (sizeof *qual, GFP_KERNEL); > + qual = kmalloc(sizeof *qual, GFP_KERNEL); > if (qual == NULL) > return; > > - status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0, > + status = usb_get_descriptor udev, USB_DT_DEVICE_QUALIFIER, 0, > qual, sizeof *qual); If you had test compiled you would have got an unbalanced parenthesis error here. So you didn't test your patch.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/