Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbHOHiR (ORCPT ); Sat, 15 Aug 2015 03:38:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37079 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbbHOHiP (ORCPT ); Sat, 15 Aug 2015 03:38:15 -0400 Date: Sat, 15 Aug 2015 00:38:30 -0700 From: Andrew Morton To: Alexander Kuleshov Cc: Tony Luck , Pekka Enberg , Mel Gorman , Baoquan He , Tang Chen , Robin Holt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] mm/memblock: validate the creation of debugfs files Message-Id: <20150815003830.c87afaff.akpm@linux-foundation.org> In-Reply-To: <20150815072636.GA2539@localhost> References: <1439579011-14918-1-git-send-email-kuleshovmail@gmail.com> <20150814141944.4172fee6c9d7ae02a6258c80@linux-foundation.org> <20150815072636.GA2539@localhost> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 37 On Sat, 15 Aug 2015 13:26:36 +0600 Alexander Kuleshov wrote: > Hello Andrew, > > On 08-14-15, Andrew Morton wrote: > > On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov wrote: > > > > > Signed-off-by: Alexander Kuleshov > > > > There's no changelog. > > Yes, will add it if there will be sense in the patch. > > > > > Why? Ignoring the debugfs API return values is standard practice. > > > > Yes, but I saw many places where this practice is applicable (for example > in the kernel/kprobes and etc.), besides this, the memblock API is used > mostly at early stage, so we will have some output if something going wrong. The debugfs error-handling rules are something Greg cooked up after one too many beers. I've never understood them, but maybe I continue to miss the point. Yes, I agree that if memblock's debugfs_create_file() fails, we want to know about it because something needs fixing. But that's true of all(?) debugfs_create_file callsites, so it's a bit silly to add warnings to them all. Why not put the warning into debugfs_create_file() itself? And add a debugfs_create_file_no_warn() if there are callsites which have reason to go it alone. Or add a debugfs_create_file_warn() wrapper. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/