Date: Sat, 15 Aug 2015 11:13:39 +0300
From: Ioan-Adrian Ratiu <adi@adirat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: andreas.dilger@intel.com, HPDD-discuss@ml01.01.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: ptlrpc: add missing include directive
Message-ID: <20150815111339.6a9f7c34@adipc>
In-Reply-To: <20150815015024.GB19664@kroah.com>
References: <1439546226-1636-1-git-send-email-adi@adirat.com>
	<20150815015024.GB19664@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 25

On Fri, 14 Aug 2015 18:50:24 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > "pack_generic.c:642:5: warning: no previous prototype for ..."
> 
> It does?  What version of gcc give you that, I don't see that here.
> 

Yes, but it's a non-default warning (-Wmissing-prototypes)

$ gcc --version
gcc (Gentoo 4.9.3 p1.0, pie-0.6.2) 4.9.3

When testing the above patch I've used Ubuntu Vivid Vervet's gcc
(also 4.9 I think, I don't have access to that machine right now).

To see the warn I'm adding "ccflags-y := -Wmissing-prototypes"
to a Makefile then "make SUBDIRS=..."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/