Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbbHOIjN (ORCPT ); Sat, 15 Aug 2015 04:39:13 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35325 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbbHOIjJ (ORCPT ); Sat, 15 Aug 2015 04:39:09 -0400 Date: Sat, 15 Aug 2015 10:38:59 +0200 From: Alexis Ballier To: Marek Vasut Cc: Ben Hutchings , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Gabor Juhos , "open list:MEMORY TECHNOLOGY DEVICES \(MTD\)" , Huang Shijie , Brian Norris , David Woodhouse , "Bean Huo =?UTF-8?B?6ZyN5paM5paM?= \(beanhuo\)" Subject: Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a. Message-ID: <20150815103859.0a15da43@gentoo.org> In-Reply-To: <201508142245.14289.marex@denx.de> References: <1439573741-24491-1-git-send-email-aballier@gentoo.org> <201508142245.14289.marex@denx.de> Organization: Gentoo X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 51 On Fri, 14 Aug 2015 22:45:14 +0200 Marek Vasut wrote: > On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote: > > It is a 256KiB flash with 4 KiB erase sectors > > and 64KiB overlay blocks. > > > > This is the one available on Hardkernel's Odroid U3 shield. > > > > Signed-off-by: Alexis Ballier > > --- > > drivers/mtd/spi-nor/spi-nor.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mtd/spi-nor/spi-nor.c > > b/drivers/mtd/spi-nor/spi-nor.c index d78831b..e521b35 100644 > > --- a/drivers/mtd/spi-nor/spi-nor.c > > +++ b/drivers/mtd/spi-nor/spi-nor.c > > @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[] > > = { { "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K | > > SST_WRITE) > }, > > { "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K > > | SST_WRITE) > }, > > { "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K > > | SST_WRITE) > }, > > + { "sst25wf020a", INFO(0x621612, 0, 64 * 1024, 4, > > SECT_4K) }, > > Is the SST_WRITE not needed on this device ? Tried that at first and it didn't work (writes were silently not performed). I'm no expert here, but I don't see anything about auto address increment in the spec: http://ww1.microchip.com/downloads/en/DeviceDoc/20005139E.pdf and it uses the page program command (0x02). Alexis. [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/