Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbbHOKLK (ORCPT ); Sat, 15 Aug 2015 06:11:10 -0400 Received: from mga02.intel.com ([134.134.136.20]:9099 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbHOKLI convert rfc822-to-8bit (ORCPT ); Sat, 15 Aug 2015 06:11:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,683,1432623600"; d="scan'208";a="784622342" From: "Drokin, Oleg" To: Ioan-Adrian Ratiu CC: Greg KH , "" , "" , "" Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive Thread-Topic: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive Thread-Index: AQHQ1vzFPaKCwz/1B0uIDUzAp4oCDp4NK/OAgAAg1YA= Date: Sat, 15 Aug 2015 10:11:06 +0000 Message-ID: <5E37ED5E-2FE2-49BF-8B7F-A40C043D95FD@intel.com> References: <1439546226-1636-1-git-send-email-adi@adirat.com> <20150815015024.GB19664@kroah.com> <20150815111339.6a9f7c34@adipc> In-Reply-To: <20150815111339.6a9f7c34@adipc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.192.119] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 34 Hello! On Aug 15, 2015, at 4:13 AM, Ioan-Adrian Ratiu wrote: >>> Without including ptlrpc_internal.h, GCC gives prototype warnings >>> "pack_generic.c:642:5: warning: no previous prototype for ..." >> It does? What version of gcc give you that, I don't see that here. > Yes, but it's a non-default warning (-Wmissing-prototypes) > > $ gcc --version > gcc (Gentoo 4.9.3 p1.0, pie-0.6.2) 4.9.3 > > When testing the above patch I've used Ubuntu Vivid Vervet's gcc > (also 4.9 I think, I don't have access to that machine right now). > > To see the warn I'm adding "ccflags-y := -Wmissing-prototypes" > to a Makefile then "make SUBDIRS=?" Duh, so essentially it tells you that you have a non-static function that lacks a previously defined prototype, but because it's non-static, it's likely used elsewhere and the prototype might get out of sync with the actual function definition? I guess it's no big deal to include the ptlrpc_internal.h there to catch potential problems like that. Thanks. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/