Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbHOMOK (ORCPT ); Sat, 15 Aug 2015 08:14:10 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:34752 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbbHOMOI (ORCPT ); Sat, 15 Aug 2015 08:14:08 -0400 X-TMN: [XgsJP14vxeiNWDHB5gPj+q4qIW1RMKP5] Message-ID: From: LIYONG To: Shawn Lin , "chris@printf.net" , "ulf.hansson@linaro.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23 Date: Sat, 15 Aug 2015 20:14:05 +0800 Importance: Normal In-Reply-To: <55CDA30E.7030208@rock-chips.com> References: <1439537446-7713-1-git-send-email-sdliyong@gmail.com>,<55CDA30E.7030208@rock-chips.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginalArrivalTime: 15 Aug 2015 12:14:05.0624 (UTC) FILETIME=[E151DB80:01D0D753] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7FCEdpD004314 Content-Length: 2362 Lines: 67 Thanks Shawn. Please help to check the below in the mmc_blk_rw_rq_prep: if (do_rel_wr) mmc_apply_rel_rw(brq, card, req); I think we need to set the do_rel_wr to false( at the beginning of this function) if the card does not support the CMD23. The above code is executed before the "if ((md->flags & MMC_BLK_CMD23)" code. Thanks, Yong Li ---------------------------------------- > Subject: Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23 > To: sdliyong@gmail.com; chris@printf.net; ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org > CC: shawn.lin@rock-chips.com > From: shawn.lin@rock-chips.com > Date: Fri, 14 Aug 2015 16:13:02 +0800 > > 在 2015/8/14 15:30, sdliyong@gmail.com 写道: >> From: Yong Li >> >> Signed-off-by: Yong Li >> --- >> drivers/mmc/card/block.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c >> index 452782b..d9e3c45 100644 >> --- a/drivers/mmc/card/block.c >> +++ b/drivers/mmc/card/block.c >> @@ -1366,7 +1366,8 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq, >> bool do_rel_wr = ((req->cmd_flags & REQ_FUA) || >> (req->cmd_flags & REQ_META)) && >> (rq_data_dir(req) == WRITE) && >> - (md->flags & MMC_BLK_REL_WR); >> + (md->flags & MMC_BLK_REL_WR) && >> + !(card->quirks & MMC_QUIRK_BLK_NO_CMD23); > > Hi Yong, > > pls check that code below. > > MMC_BLK_REL_WR will not be enabled if we know this card CANNOT support > CMD23 form SCR. AND， "card->quirks & MMC_QUIRK_BLK_NO_CMD23" would be > checked here as well. So I think your code is unnecessary. > > if ((md->flags & MMC_BLK_CMD23) && mmc_op_multi(brq->cmd.opcode) && > (do_rel_wr || !(card->quirks & MMC_QUIRK_BLK_NO_CMD23) || > do_data_tag)) { > brq->sbc.opcode = MMC_SET_BLOCK_COUNT; > brq->sbc.arg = brq->data.blocks | > (do_rel_wr ? (1 << 31) : 0) | > (do_data_tag ? (1 << 29) : 0); > brq->sbc.flags = MMC_RSP_R1 | MMC_CMD_AC; > brq->mrq.sbc = &brq->sbc; > } > > Thanks. > Shawn > >> >> memset(brq, 0, sizeof(struct mmc_blk_request)); >> brq->mrq.cmd = &brq->cmd; >> > > > -- > Shawn Lin > ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?