Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753806AbbHOQLj (ORCPT ); Sat, 15 Aug 2015 12:11:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41135 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbbHOQLh (ORCPT ); Sat, 15 Aug 2015 12:11:37 -0400 Date: Sat, 15 Aug 2015 09:11:36 -0700 From: Greg KH To: Ioan-Adrian Ratiu Cc: andreas.dilger@intel.com, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: ptlrpc: add missing include directive Message-ID: <20150815161136.GA25644@kroah.com> References: <1439546226-1636-1-git-send-email-adi@adirat.com> <20150815015024.GB19664@kroah.com> <20150815111339.6a9f7c34@adipc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150815111339.6a9f7c34@adipc> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 26 On Sat, Aug 15, 2015 at 11:13:39AM +0300, Ioan-Adrian Ratiu wrote: > On Fri, 14 Aug 2015 18:50:24 -0700 > Greg KH wrote: > > > On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: > > > Without including ptlrpc_internal.h, GCC gives prototype warnings > > > "pack_generic.c:642:5: warning: no previous prototype for ..." > > > > It does? What version of gcc give you that, I don't see that here. > > > > Yes, but it's a non-default warning (-Wmissing-prototypes) Then you should say that, otherwise you have us worrying something is really wrong with our build/compiler versions... I've taken this patch, but next time please be more specific. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/