Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750885AbbHPF3h (ORCPT ); Sun, 16 Aug 2015 01:29:37 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:45410 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbbHPF3f (ORCPT ); Sun, 16 Aug 2015 01:29:35 -0400 Date: Sun, 16 Aug 2015 13:28:58 +0800 From: joeyli To: Pavel Machek Cc: "Lee, Chun-Yi" , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Josh Boyer , Vojtech Pavlik , Matt Fleming , Jiri Kosina , "H. Peter Anvin" , Ingo Molnar Subject: Re: [PATCH v2 08/16] x86/efi: Carrying hibernation key by setup data Message-ID: <20150816052858.GE13488@linux-rxt1.site> References: <1439273796-25359-1-git-send-email-jlee@suse.com> <1439273796-25359-9-git-send-email-jlee@suse.com> <20150815170737.GA25353@Nokia-N900> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150815170737.GA25353@Nokia-N900> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2676 Lines: 80 On Sat, Aug 15, 2015 at 07:07:38PM +0200, Pavel Machek wrote: > On Tue 2015-08-11 14:16:28, Lee, Chun-Yi wrote: > > For forwarding hibernation key from EFI stub to boot kernel, this patch > > allocates setup data for carrying hibernation key, size and the status > > of efi operating. > > > > Reviewed-by: Jiri Kosina > > Jiri, are you sure you reviewed these? This is not really > english, afaict, and efi/EFI should be spelled consistently. > > Could you try reviewing it again? Pointing out 10s of small > bugs is quite boring... > It's my fault, I will find someone help to review my English in all patch description for next edition. > > unsigned long key_size; > > unsigned long attributes; > > + struct setup_data *setup_data, *hibernation_setup_data; > > struct hibernation_keys *keys; > > + unsigned long size = 0; > > efi_status_t status; > > > > /* Allocate setup_data to carry keys */ > > + size = sizeof(struct setup_data) + sizeof(struct hibernation_keys); > > status = efi_call_early(allocate_pool, EFI_LOADER_DATA, > > - sizeof(struct hibernation_keys), &keys); > > + size, &hibernation_setup_data); > > if (status != EFI_SUCCESS) { > > efi_printk(sys_table, "Failed to alloc mem for hibernation keys\n"); > > return; > > } > > > > - memset(keys, 0, sizeof(struct hibernation_keys)); > > + memset(hibernation_setup_data, 0, size); > > + keys = (struct hibernation_keys *) hibernation_setup_data->data; > > > > any chance to type stuff correctly so that casts are not > neccessary? > The data element defined in setup_data struct as u8: __u8 data[0]; So I use cast here. > > +clean_fail: > > + hibernation_setup_data->type = SETUP_HIBERNATION_KEYS; > > + hibernation_setup_data->len = sizeof(struct hibernation_keys); > > + hibernation_setup_data->next = 0; > > + keys->hkey_status = efi_status_to_err(status); > > + > > + setup_data = (struct setup_data *)params->hdr.setup_data; > > + while (setup_data && setup_data->next) > > + setup_data = (struct setup_data *)setup_data->next; > > way too many casts here. > > Pavel I follow setup_efi_pci32() and setup_efi_pci64(): while (data && data->next) data = (struct setup_data *)(unsigned long)data->next; That's better I also add (unsigned long) cast as setup_efi_pci. Do you have good suggestion let the above code more graceful? Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/