Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbbHPSMn (ORCPT ); Sun, 16 Aug 2015 14:12:43 -0400 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:34707 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbbHPSMm (ORCPT ); Sun, 16 Aug 2015 14:12:42 -0400 Date: Sun, 16 Aug 2015 20:12:35 +0200 From: Florian Westphal To: Phil Sutter Cc: Thomas Graf , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH] rhashtable-test: extend to test concurrency Message-ID: <20150816181234.GC31357@breakpoint.cc> References: <1439591835-30357-1-git-send-email-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439591835-30357-1-git-send-email-phil@nwl.cc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 614 Lines: 19 Phil Sutter wrote: > After having tested insertion, lookup, table walk and removal, spawn a > number of threads running operations on the same rhashtable. Each of > them will: [..] > + if (down_interruptible(&startup_sem)) > + pr_err(" thread[%d]: down_interruptible failed\n", tdata->id); Why _interruptible? Seems this should use down() instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/