Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbbHPW0a (ORCPT ); Sun, 16 Aug 2015 18:26:30 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:43690 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbbHPW03 (ORCPT ); Sun, 16 Aug 2015 18:26:29 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 17 Aug 2015 00:26:28 +0200 X-ME-IP: 90.5.13.86 From: Robert Jarzmik To: Ezequiel Garcia Cc: Brian Norris , Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Antoine Tenart Subject: Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <1439323034-8820-3-git-send-email-robert.jarzmik@free.fr> <20150816213655.GA4585@laptop.cereza> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 17 Aug 2015 00:22:28 +0200 In-Reply-To: <20150816213655.GA4585@laptop.cereza> (Ezequiel Garcia's message of "Sun, 16 Aug 2015 18:36:55 -0300") Message-ID: <87oai6an6j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 38 Ezequiel Garcia writes: > On 11 Aug 09:57 PM, Robert Jarzmik wrote: >> The cases of READID detection are broken on pxa3xx. The reason is that >> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we >> always have : >> - info->use_dma = 0 (regardless of dma support yet) >> - info->chunk_size = 0 (not yet detected) >> >> The READID issued by pxa3xx_nand_scan() will therefore end up in >> handle_data_pio(), and do_bytes will be 0, leading to not reading the >> nand id, and blocking detection. >> >> This doesn't happen if "keep_config" is used, which is probably the most >> tested case. >> >> Signed-off-by: Robert Jarzmik >> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O >> support") > > To be fair, Antoine submitted this a while ago: > > http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html > > Not sure which one takes precedence in such a case (and yours > has a proper Fixes tag). His has precedence. How is it that a fix patch is not yet merge since April ? Is it because it's part of a still in review serie ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/