Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752846AbbHQAeT (ORCPT ); Sun, 16 Aug 2015 20:34:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:52013 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbHQAdx (ORCPT ); Sun, 16 Aug 2015 20:33:53 -0400 Date: Mon, 17 Aug 2015 10:33:41 +1000 From: NeilBrown To: Greg KH Cc: stable@vger.kernel.org, linux-raid , GuoQing Jiang , Goldwyn Rodrigues , lkml Subject: Re: [PATCH stable] md/bitmap: return an error when bitmap superblock is corrupt. Message-ID: <20150817103341.1b444214@noble> In-Reply-To: <20150814172351.GB17745@kroah.com> References: <20150814170421.60d40eb0@noble> <20150814172351.GB17745@kroah.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 34 On Fri, 14 Aug 2015 10:23:51 -0700 Greg KH wrote: > On Fri, Aug 14, 2015 at 05:04:21PM +1000, NeilBrown wrote: > > > > commit b97e92574c0bf335db1cd2ec491d8ff5cd5d0b49 upstream > > Use separate bitmaps for each nodes in the cluster > > > > bitmap_read_sb() validates the bitmap superblock that it reads in. > > If it finds an inconsistency like a bad magic number or out-of-range > > version number, it prints an error and returns, but it incorrectly > > returns zero, so the array is still assembled with the (invalid) bitmap. > > > > This means it could try to use a bitmap with a new version number which > > it therefore does not understand. > > > > This bug was introduced in 3.5 and fix as part of a larger patch in 4.1. > > So the patch is suitable for any -stable kernel in that range. > > > > Fixes: 27581e5ae01f ("md/bitmap: centralise allocation of bitmap file pages.") > > Cc: stable@vger.kernel.org (v3.5..v4.1) > > b97e92574c0 is in 4.1, so do you mean (v3.5..v4.0) here? > Yes, I did. Thanks! v3.5..v4.0. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/