Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbbHQBFk (ORCPT ); Sun, 16 Aug 2015 21:05:40 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:58446 "EHLO mx6-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbbHQBFj (ORCPT ); Sun, 16 Aug 2015 21:05:39 -0400 Date: Sun, 16 Aug 2015 21:05:37 -0400 (EDT) From: Brad Hubbard To: linux-kernel Cc: zyan@redhat.com, sage@redhat.com Message-ID: <1876245679.2939973.1439773537944.JavaMail.zimbra@redhat.com> In-Reply-To: <1548910686.2935580.1439772740199.JavaMail.zimbra@redhat.com> Subject: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.48.171] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF39 (Linux)/8.0.6_GA_5922) Thread-Topic: ceph: remove redundant test of head->safe and silence static analysis warnings Thread-Index: 6ieUDx8GJ2MyLG5f7VAWYRl7/RElWw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 26 ceph: remove redundant test of head->safe and silence static analysis warnings Signed-off-by: Brad Hubbard --- fs/ceph/mds_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 6aa07af..6e196ee 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) mutex_unlock(&mdsc->mutex); goto out; } - if (req->r_got_safe && !head->safe) { + if (req->r_got_safe) { pr_warn("got unsafe after safe on %llu from mds%d\n", tid, mds); mutex_unlock(&mdsc->mutex); -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/