Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbbHQBsk (ORCPT ); Sun, 16 Aug 2015 21:48:40 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:35409 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbbHQBsK (ORCPT ); Sun, 16 Aug 2015 21:48:10 -0400 X-AuditID: cbfee68f-f793b6d000005f66-49-55d13d491d3a Message-id: <55D13D49.1040504@samsung.com> Date: Mon, 17 Aug 2015 10:47:53 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , rtc-linux@googlegroups.com Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, sbkim73@samsung.com Subject: Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <55CC6B28.5010707@samsung.com> In-reply-to: <55CC6B28.5010707@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWyRsSkRNfT9mKowbXDOhZLLl5lt+i4tpjJ 4vULQ4vLu+awWcw4v4/JYn9nB6PFxRVfmCwWbHzE6MDh8WTTRUaPPRNPsnn0bVnF6DF93k8m j8+b5AJYo7hsUlJzMstSi/TtErgy3u3fwFpwSaHi7IrZ7A2Ma0W6GDk5JARMJPbMns4EYYtJ XLi3nq2LkYtDSGAFo8SnDxuYYYoefz4ElZjFKHF3Rh8LhPOAUeLw7T2MIFW8AloSG7/uZAex WQRUJX7uvMcGYrMJ6Enc2XYcbIWoQJjEmRkdLBD1ghI/Jt8Ds0UEfCUerDwKNpRZYAOjxLxj V8EGCQu4SUx49xOsWUggQ2Lu1EZWEJtTQFti6dVLQA0cQA3qElOm5IKEmQXkJTavecsMMkdC 4Ba7xNNX+5khDhKQ+Db5EFi9hICsxKYDUJ9JShxccYNlAqPYLCQnzUKYOgvJ1AWMzKsYRVML kguKk9KLjPWKE3OLS/PS9ZLzczcxAuPv9L9n/TsY7x6wPsQowMGoxMN74eeFUCHWxLLiytxD jKZAR0xklhJNzgdGeV5JvKGxmZGFqYmpsZG5pZmSOO9CqZ/BQgLpiSWp2ampBalF8UWlOanF hxiZODilGhhV7/1fXrZ2gjWnx+Lnyt93nDj4rbaj6YhO8x0rvaOBCfa7vmz0zNFa11feq84l m8Ia93Xj1XwJt2TuU2em62yuCGXPqyk6yGj2r+6yYkmBUO9+JbWAzFIFfaZNH2VUf/DpWpdF FAg+CPLjqSziXXiz8NLmcln18wEXlLpy5s39EbY39rBDgxJLcUaioRZzUXEiANSVbc+6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t9jQV1P24uhBlufKFosuXiV3aLj2mIm i9cvDC0u75rDZjHj/D4mi/2dHYwWF1d8YbJYsPERowOHx5NNFxk99kw8yebRt2UVo8f0eT+Z PD5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmPFu/wbWgksKFWdX zGZvYFwr0sXIySEhYCLx+PMhNghbTOLCvfVANheHkMAsRom7M/pYIJwHjBKHb+9hBKniFdCS 2Ph1JzuIzSKgKvFz5z2wbjYBPYk7244zgdiiAmESZ2Z0sEDUC0r8mHwPzBYR8JV4sPIo2FBm gQ2MEvOOXQUbJCzgJjHh3U+wZiGBDIm5UxtZQWxOAW2JpVcvATVwADWoS0yZkgsSZhaQl9i8 5i3zBEagMxFWzEKomoWkagEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Bh/Jr2D 8fAu90OMAhyMSjy8Gn8uhAqxJpYVV+YeYpTgYFYS4b0rcDFUiDclsbIqtSg/vqg0J7X4EKMp MAwmMkuJJucD009eSbyhsYmZkaWRuaGFkbG5kjivvsmmUCGB9MSS1OzU1ILUIpg+Jg5OqQbG OSWPV/Wt2Pf81+4FGUw/Foe8mxC9qWvX1ta7XefUXqdcncn/yCD21l/LxIqKP3+/CglkmTJ4 /TvXU1dxa/ZZtcSYRecsZ6XZPH+bvNDh8L/9vLbfJko6lK3fY70ggLlt6tP9zqdEJn9rTrpT /LezLH9DojLjpB9cdXW7X+0w3Vn81Sz3nstLPiWW4oxEQy3mouJEABiiABAHAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4310 Lines: 118 Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: > W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. > > Hi, > > I cannot find this information in S2MPS14 datasheet. On which page is it? > I got below information from S2MPS14_Data Sheet_REV0.1 document. 5.2.2.3 RTC_UPDATE ... NOTE: 1. For write Time Registers (0x00, 0x04~0x0A) & Alarm 0&1 Registers (0x0B~0x18), set WUDR bit to high. > >> >> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >> tools/testing/selftests/timers/rtctest.c test program and hour format is >> used to 12 hour mode in Odroid-XU3 board. > > Two questions here: > 1. Earlier you mentioned S2MPS1[34], now Odroid XU3 which has S2MPS11. > Are you sure that this applies to all of them (S2MPS11, S2MPS13 and > S2MP14)? There are some minor differences between them so I would not be > surprised if only some of them required this action. > I'm not sure about that because i don't have S2MPS11 datasheet. I just got the information that S2MPS11 also use S2MPS14 rtc from sec-core mfd driver, static const struct mfd_cell s2mps11_devs[] = { { .name = "s2mps11-pmic", }, { .name = "s2mps14-rtc", }, { .name = "s2mps11-clk", .of_compatible = "samsung,s2mps11-clk", } }; > 2. The driver operates in 24-hour omode. Actually it sets the 24-hour > mode just before your new regmap_update_bits() call. What do you mean by > 12-hour mode? > RTC_CTRL register value is 0 until write buffer is updated, so it is used to 12-hour mode. >> Signed-off-by: Joonyoung Shim >> Cc: > > Thanks for putting a cc-stable tag. How far this should be ported? If > this is needed only for S2MPS11 then v4.1. If all of them then probably > for earlier version? > If find exact version, i think it will be a version after below commit was applied. The commit 0c5deb1ea92f("rtc: s5m: add support for S2MPS14 RTC") $ git name-rev 0c5deb1ea92f 0c5deb1ea92f tags/v3.16-rc1~53^2~1 Thanks. > Best regards, > Krzysztof > >> --- >> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >> index 8c70d78..03828bb 100644 >> --- a/drivers/rtc/rtc-s5m.c >> +++ b/drivers/rtc/rtc-s5m.c >> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >> case S2MPS13X: >> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >> + if (ret < 0) >> + break; >> + >> + ret = regmap_update_bits(info->regmap, >> + info->regs->rtc_udr_update, >> + info->regs->rtc_udr_mask, >> + info->regs->rtc_udr_mask); >> + if (ret < 0) >> + break; >> + >> + ret = s5m8767_wait_for_udr_update(info); >> + >> break; >> >> default: >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/