Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753593AbbHQC3F (ORCPT ); Sun, 16 Aug 2015 22:29:05 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:59756 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbbHQC3B (ORCPT ); Sun, 16 Aug 2015 22:29:01 -0400 X-AuditID: cbfee691-f79ca6d00000456a-32-55d146d3a580 Message-id: <55D146D3.3000500@samsung.com> Date: Mon, 17 Aug 2015 11:28:35 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , rtc-linux@googlegroups.com Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, sbkim73@samsung.com Subject: Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <55CC6B28.5010707@samsung.com> <55D13D49.1040504@samsung.com> <55D14033.1000000@samsung.com> In-reply-to: <55D14033.1000000@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWyRsSkQPey28VQg94dchZLLl5lt+i4tpjJ 4vULQ4vLu+awWcw4v4/JYn9nB6PFxRVfmCwWbHzE6MDh8WTTRUaPPRNPsnn0bVnF6DF93k8m j8+b5AJYo7hsUlJzMstSi/TtErgyttz8zlawUadi1f6dzA2MT2S7GDk5JARMJLp372WBsMUk LtxbzwZiCwmsYJT4+9UWpmb33LlANVxA8aWMEm/7p7BCOA8YJfq/nwLr4BXQkljatADMZhFQ lVhwbjMjiM0moCdxZ9txJhBbVCBM4syMDhaIekGJH5PvgdkiAr4SD1YeBdvALLCBUWLesavs IAlhATeJCe9+MkFsAzrpwdqDzCAJTgFtiW9HbgDZHEAd6hJTpuSChJkF5CU2r3nLDFIvIXCP XWLVxWdMEBcJSHybfIgFpF5CQFZi0wFmiNckJQ6uuMEygVFsFpKbZiFMnYVk6gJG5lWMoqkF yQXFSelFpnrFibnFpXnpesn5uZsYgfF3+t+ziTsY7x+wPsQowMGoxMOr8edCqBBrYllxZe4h RlOgIyYyS4km5wOjPK8k3tDYzMjC1MTU2Mjc0kxJnFdH+mewkEB6YklqdmpqQWpRfFFpTmrx IUYmDk6pBsaVM9SS+o5ycB6p0eJedJLB0NfIMVLKZNq//M+P85clFJddX2V6xslU7mP0aZvJ q8WeimyKFBEyUozfFGEVPbnXfkq79Ns8dSb598knRda89lmw4W6DUU2AVf3jg4Z7dt+/LbDF WtDRIcX6c5/mVT2VE/29+ieZHGN8fizWsvv7Y42ubM6f5UosxRmJhlrMRcWJACoUBJm6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jAd3LbhdDDc50SVgsuXiV3aLj2mIm i9cvDC0u75rDZjHj/D4mi/2dHYwWF1d8YbJYsPERowOHx5NNFxk99kw8yebRt2UVo8f0eT+Z PD5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmLHl5ne2go06Fav2 72RuYHwi28XIySEhYCKxe+5cFghbTOLCvfVsXYxcHEICSxkl3vZPYYVwHjBK9H8/xQZSxSug JbG0aQGYzSKgKrHg3GZGEJtNQE/izrbjTCC2qECYxJkZHSwQ9YISPybfA7NFBHwlHqw8ygIy lFlgA6PEvGNX2UESwgJuEhPe/WSC2LaCUeLB2oPMIAlOAW2Jb0duANkcQB3qElOm5IKEmQXk JTavecs8gVFgFpIdsxCqZiGpWsDIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOMqf Se1gPLjL/RCjAAejEg+vxp8LoUKsiWXFlbmHGCU4mJVEeO8KXAwV4k1JrKxKLcqPLyrNSS0+ xGgKDISJzFKiyfnABJRXEm9obGJmZGlkbmhhZGyuJM4ru2FzqJBAemJJanZqakFqEUwfEwen VAOj4fonLM7uKZdufFGpXxZctzdZV3bBR5F2NnO+Jzrs6wp4gqqTz7HervE+fdHc7KGB/yy/ ZJd43pLnTZbszFr2pfOMl2Vck3YPDjyXUpT+872CTU7xoz1fDv+96bjgxiuVo99XuvG+kT2n 1C7hti1g5X2WBQEdLpaPvjEz6553ib8cUJRy10uJpTgj0VCLuag4EQDMIwFfCAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5771 Lines: 160 On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: > On 17.08.2015 10:47, Joonyoung Shim wrote: >> Hi, >> >> On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: >>> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >>>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>>> buffer via setting WUDR bit to high after ctrl register is updated. >>> >>> Hi, >>> >>> I cannot find this information in S2MPS14 datasheet. On which page is it? >>> >> >> I got below information from S2MPS14_Data Sheet_REV0.1 document. >> >> 5.2.2.3 RTC_UPDATE >> ... >> >> NOTE: >> 1. For write Time Registers (0x00, 0x04~0x0A) & Alarm 0&1 Registers >> (0x0B~0x18), set WUDR bit to high. > > Right, I have too but it does not say anything about control register. > It mentions only time, alarm 0 and alarm 1 registers, not control. > Address 0x00 is RTC_CTRL, so i don't know what you say. >> >>> >>>> >>>> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >>>> tools/testing/selftests/timers/rtctest.c test program and hour format is >>>> used to 12 hour mode in Odroid-XU3 board. >>> >>> Two questions here: >>> 1. Earlier you mentioned S2MPS1[34], now Odroid XU3 which has S2MPS11. >>> Are you sure that this applies to all of them (S2MPS11, S2MPS13 and >>> S2MP14)? There are some minor differences between them so I would not be >>> surprised if only some of them required this action. >>> >> >> I'm not sure about that because i don't have S2MPS11 datasheet. I just >> got the information that S2MPS11 also use S2MPS14 rtc from sec-core mfd >> driver, > > Yeah, I added it. But these RTC modules are slightly different, > especially S2MPS14, so you cannot assume that they are the same after > looking at mainline code. > OK, could you check this issue from different things? Thanks. >> >> static const struct mfd_cell s2mps11_devs[] = { >> { >> .name = "s2mps11-pmic", >> }, { >> .name = "s2mps14-rtc", >> }, { >> .name = "s2mps11-clk", >> .of_compatible = "samsung,s2mps11-clk", >> } >> }; >> >>> 2. The driver operates in 24-hour omode. Actually it sets the 24-hour >>> mode just before your new regmap_update_bits() call. What do you mean by >>> 12-hour mode? >>> >> >> RTC_CTRL register value is 0 until write buffer is updated, so it is >> used to 12-hour mode. > > I mean what do you have in mind by saying: > "... and hour format is used to 12 hour mode in Odroid-XU3 board." > The hour format is set by driver to 24h mode. > > >> >>>> Signed-off-by: Joonyoung Shim >>>> Cc: >>> >>> Thanks for putting a cc-stable tag. How far this should be ported? If >>> this is needed only for S2MPS11 then v4.1. If all of them then probably >>> for earlier version? >>> >> >> If find exact version, i think it will be a version after below commit >> was applied. >> >> The commit 0c5deb1ea92f("rtc: s5m: add support for S2MPS14 RTC") >> >> $ git name-rev 0c5deb1ea92f >> 0c5deb1ea92f tags/v3.16-rc1~53^2~1 > > Hmmm... I am not against the patch (especially that it matches source > code of SM-G900H with S2MPS11) but I have doubts about affected > chipsets. My Odroid (probably because of bootloader), S2MPS13 and > S2MPS14 do not need it. This confuses me... > > Best regards, > Krzysztof > >> >> Thanks. >> >>> Best regards, >>> Krzysztof >>> >>>> --- >>>> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >>>> index 8c70d78..03828bb 100644 >>>> --- a/drivers/rtc/rtc-s5m.c >>>> +++ b/drivers/rtc/rtc-s5m.c >>>> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >>>> case S2MPS13X: >>>> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >>>> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >>>> + if (ret < 0) >>>> + break; >>>> + >>>> + ret = regmap_update_bits(info->regmap, >>>> + info->regs->rtc_udr_update, >>>> + info->regs->rtc_udr_mask, >>>> + info->regs->rtc_udr_mask); >>>> + if (ret < 0) >>>> + break; >>>> + >>>> + ret = s5m8767_wait_for_udr_update(info); >>>> + >>>> break; >>>> >>>> default: >>>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/