Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbbHQFx7 (ORCPT ); Mon, 17 Aug 2015 01:53:59 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:50364 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbbHQFx5 (ORCPT ); Mon, 17 Aug 2015 01:53:57 -0400 X-Helo: d01dlp01.pok.ibm.com X-MailFrom: ego@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 17 Aug 2015 11:23:45 +0530 From: Gautham R Shenoy To: Sam Bobroff Cc: "Gautham R. Shenoy" , Paul Mackerras , Benjamin Herrenschmidt , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, "Aneesh Kumar K.V" Subject: Re: [PATCH] book3s_hv_rmhandlers:Pass the correct trap argument to kvmhv_commence_exit Message-ID: <20150817055345.GA13304@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <1432196824-21791-1-git-send-email-ego@linux.vnet.ibm.com> <20150814050728.GB13544@tungsten.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150814050728.GB13544@tungsten.ozlabs.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15081705-0033-0000-0000-0000058498C5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 38 Hi Sam, On Fri, Aug 14, 2015 at 03:07:28PM +1000, Sam Bobroff wrote: > On Thu, May 21, 2015 at 01:57:04PM +0530, Gautham R. Shenoy wrote: > > In guest_exit_cont we call kvmhv_commence_exit which expects the trap > > number as the argument. However r3 doesn't contain the trap number at > > this point and as a result we would be calling the function with a > > spurious trap number. > > > > Fix this by copying r12 into r3 before calling kvmhv_commence_exit as > > r12 contains the trap number > > > > Signed-off-by: Gautham R. Shenoy > > Hi Gautham, > > I agree with your logic: r3 is quite clearly corrupted in that path. So: > > Reviewed-by: Sam Bobroff > > Just one comment: Do you have a case of this causing some visible problem due > to the corrupted trap number? (I'll test the patch if you do.) > Actually no! I found this bug while reviewing the code for some other issue. > Cheers, > Sam. -- Thanks and Regards gautham. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/