Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbbHQGjQ (ORCPT ); Mon, 17 Aug 2015 02:39:16 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:58627 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbHQGjO (ORCPT ); Mon, 17 Aug 2015 02:39:14 -0400 Date: Mon, 17 Aug 2015 08:39:05 +0200 From: Markus Pargmann To: Peter Meerwald Cc: Jonathan Cameron , Srinivas Pandruvada , Vlad Dogaru , Paul Bolle , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v3 6/6] iio: bmg160: Add SPI driver Message-ID: <20150817063905.GF19600@pengutronix.de> References: <1439391009-6051-1-git-send-email-mpa@pengutronix.de> <1439391009-6051-7-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OVGC6gYtotzLWy7n" Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:37:21 up 15 days, 10:11, 89 users, load average: 1.37, 1.38, 1.46 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5645 Lines: 181 --OVGC6gYtotzLWy7n Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 12, 2015 at 05:19:37PM +0200, Peter Meerwald wrote: > On Wed, 12 Aug 2015, Markus Pargmann wrote: >=20 > > Signed-off-by: Markus Pargmann >=20 > the spelling of Bosch is inconsistent, sometimes it is BOSCH, I'd prefer= =20 > the former Right, I can fix it in this patch, yes. >=20 > please find a slightly more relevant comment below :) >=20 > > --- > > drivers/iio/gyro/Kconfig | 11 +++++++++ > > drivers/iio/gyro/Makefile | 1 + > > drivers/iio/gyro/bmg160_spi.c | 57 +++++++++++++++++++++++++++++++++++= ++++++++ > > 3 files changed, 69 insertions(+) > > create mode 100644 drivers/iio/gyro/bmg160_spi.c > >=20 > > diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig > > index 13f8e0051615..a77dbb0062fe 100644 > > --- a/drivers/iio/gyro/Kconfig > > +++ b/drivers/iio/gyro/Kconfig > > @@ -71,6 +71,17 @@ config BMG160_I2C > > This driver can also be built as a module. If so, the module > > will be called bmg160_i2c. > > =20 > > +config BMG160_SPI > > + tristate "Driver for connection via SPI" > > + depends on SPI > > + select REGMAP_SPI > > + help > > + Say yes here to build support for Bosch BMG160 Tri-axis Gyro Sensor > > + driver connected via SPI. This driver also supports BMI055 gyroscop= e. > > + > > + This driver can also be built as a module. If so, the module > > + will be called bmg160_spi. > > + > > endif > > =20 > > config HID_SENSOR_GYRO_3D > > diff --git a/drivers/iio/gyro/Makefile b/drivers/iio/gyro/Makefile > > index 73b41e43a974..848e55c605c0 100644 > > --- a/drivers/iio/gyro/Makefile > > +++ b/drivers/iio/gyro/Makefile > > @@ -9,6 +9,7 @@ obj-$(CONFIG_ADIS16136) +=3D adis16136.o > > obj-$(CONFIG_ADIS16260) +=3D adis16260.o > > obj-$(CONFIG_ADXRS450) +=3D adxrs450.o > > obj-$(CONFIG_BMG160_I2C) +=3D bmg160_core.o bmg160_i2c.o > > +obj-$(CONFIG_BMG160_I2C) +=3D bmg160_core.o bmg160_spi.o > > =20 > > obj-$(CONFIG_HID_SENSOR_GYRO_3D) +=3D hid-sensor-gyro-3d.o > > =20 > > diff --git a/drivers/iio/gyro/bmg160_spi.c b/drivers/iio/gyro/bmg160_sp= i.c > > new file mode 100644 > > index 000000000000..8a358571b702 > > --- /dev/null > > +++ b/drivers/iio/gyro/bmg160_spi.c > > @@ -0,0 +1,57 @@ > > +#include > > +#include > > +#include > > +#include > > + > > +#include >=20 > I think this should be > #include "bmg160.h" > as in the _i2c part of the driver Yes, thanks. Best regards, Markus >=20 > > + > > +static const struct regmap_config bmg160_regmap_spi_conf =3D { > > + .reg_bits =3D 8, > > + .val_bits =3D 8, > > + .max_register =3D 0x3f, > > +}; > > + > > +static int bmg160_spi_probe(struct spi_device *spi) > > +{ > > + struct regmap *regmap; > > + const struct spi_device_id *id =3D spi_get_device_id(spi); > > + > > + regmap =3D devm_regmap_init_spi(spi, &bmg160_regmap_spi_conf); > > + if (IS_ERR(regmap)) { > > + dev_err(&spi->dev, "Failed to register spi regmap %d\n", > > + (int)PTR_ERR(regmap)); > > + return PTR_ERR(regmap); > > + } > > + > > + return bmg160_core_probe(&spi->dev, regmap, spi->irq, id->name); > > +} > > + > > +static int bmg160_spi_remove(struct spi_device *spi) > > +{ > > + bmg160_core_remove(&spi->dev); > > + > > + return 0; > > +} > > + > > +static const struct spi_device_id bmg160_spi_id[] =3D { > > + {"bmg160", 0}, > > + {"bmi055_gyro", 0}, > > + {} > > +}; > > + > > +MODULE_DEVICE_TABLE(spi, bmg160_spi_id); > > + > > +static struct spi_driver bmg160_spi_driver =3D { > > + .driver =3D { > > + .name =3D "bmg160_spi", > > + .pm =3D &bmg160_pm_ops, > > + }, > > + .probe =3D bmg160_spi_probe, > > + .remove =3D bmg160_spi_remove, > > + .id_table =3D bmg160_spi_id, > > +}; > > +module_spi_driver(bmg160_spi_driver); > > + > > +MODULE_AUTHOR("Markus Pargmann "); > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("BMG160 SPI Gyro driver"); > >=20 >=20 > --=20 >=20 > Peter Meerwald > +43-664-2444418 (mobile) >=20 --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --OVGC6gYtotzLWy7n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV0YGJAAoJEEpcgKtcEGQQcmIP/1JTu/Tw38N/4VhH/LhVTZvq 0O/SqJGIx2oOq+9dgFChiRn1BLcKHcbrRjjsLri9PPfys+n0SbDGZTmt0I8ZfE/6 Com2ollRZDgQC9UkfymjPg4vz78JLA0sxU7f9zndqvQXdwsuDQDk8yg/0HWoiG7x 2DcDQrG4equ7ArH2/sDyGP0oa2hYNgP8/FjT60dpsAnPW972n465tH2SAhTQWstZ r2LQk6OV7vAlne/nptE30clBjag5Dtvbwppb9ub1VIs/XxDxRP/N6Zr81wq6tT/B Nq8PEOiYNuzFSMkW9kZSqDg4BYqS8rl9s/sZR2GVYOjad2V5m73s0cQAZ8OHH87u 4NbySM9XGrfOQKqRajeEyZJaqETxs6QY5E9eOVxB9ZzlOxYPKShUc91PJQtRB8WX kONuADzAVZHtWWzU/zXfoVrot/Rx9aGXIWcqfIJ4TKYNG+QfOWs39K9TY8IL36cQ pfejUfkxsmSBZAZmQNNsha9kXHgz3Mwlb127jv+1WA5aXWO7LDHAawF7zJWRn4kT XYsT69lgWwFlpFQ7tRLbarpw+dWn5ja9/6IWOd3XX6nXsxyMdn8NcKHsMHjzu8Fo T3SwlYnopWNJI4kp5IQszg6TkKsLAr3alqGb8+pvuAs/+S4VhzP5+7ouFHBNX8L9 ZQNOZSkTlqAfcnplQuxx =rmTK -----END PGP SIGNATURE----- --OVGC6gYtotzLWy7n-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/