Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbbHQH46 (ORCPT ); Mon, 17 Aug 2015 03:56:58 -0400 Received: from mail-ob0-f194.google.com ([209.85.214.194]:35290 "EHLO mail-ob0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbbHQH44 (ORCPT ); Mon, 17 Aug 2015 03:56:56 -0400 MIME-Version: 1.0 In-Reply-To: <1435191645-6022-2-git-send-email-javier.martinez@collabora.co.uk> References: <1435191645-6022-1-git-send-email-javier.martinez@collabora.co.uk> <1435191645-6022-2-git-send-email-javier.martinez@collabora.co.uk> Date: Mon, 17 Aug 2015 09:56:55 +0200 X-Google-Sender-Auth: mQOd3NNwxcvDObqRWFCjXA8nuGg Message-ID: Subject: Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM From: Geert Uytterhoeven To: Javier Martinez Canillas Cc: Lee Jones , "linux-samsung-soc@vger.kernel.org" , Heiko Stuebner , Paul Gortmaker , Gwendal Grignou , Doug Anderson , "linux-kernel@vger.kernel.org" , Samuel Ortiz , Olof Johansson , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 39 On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas wrote: > The Chrome platform support depends on X86 || ARM because there are > only Chromebooks using those architectures. But only some drivers > depend on a given architecture, and the ones that do already have > a dependency on their specific Kconfig symbol entries. > > An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST > but is more future proof to remove the dependency and let the drivers > be built in all architectures if possible to have more build coverage. > > Signed-off-by: Javier Martinez Canillas NAKed-by: Geert Uytterhoeven The proper way to have more build coverage is to extend the dependencies with "|| COMPILE_TEST". Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a Kconfig warning on !X86 and !ARM. Mixing "select" and "depends" (all other ChromeOS stuff depends on the symbol) is bad practice, as it may lead to circular Kconfig dependencies. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/