Date: Mon, 17 Aug 2015 16:20:24 +0800
From: Li Jun <b47624@freescale.com>
To: Baolin Wang <baolin.wang@linaro.org>
CC: Felipe Balbi <balbi@ti.com>, Mark Brown <broonie@kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Peter Chen <peter.chen@freescale.com>, <sojka@merica.cz>,
        Alan Stern <stern@rowland.harvard.edu>, <r.baldyga@samsung.com>,
        <yoshihiro.shimoda.uh@renesas.com>, <linux-usb@vger.kernel.org>,
        <device-mainlining@lists.linuxfoundation.org>, <sre@kernel.org>,
        "Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>, <sameo@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        <patches@opensource.wolfsonmicro.com>, <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Introduce usb charger framework to deal with the
 usb gadget power negotation
Message-ID: <20150817082023.GB7122@shlinux2>
References: <cover.1439519412.git.baolin.wang@linaro.org>
 <20150814085527.GA17920@shlinux2>
 <CAMz4kuK7f=rGOO-YdB0AB8PzpTbnWZtasuQK8gOXLuM9zyn3gw@mail.gmail.com>
 <20150817011541.GA7122@shlinux2>
 <CAMz4kuJGR1ZQPbBNpp7EABJn=Rag8jSrb-2ztcefUf4R7pk4AQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAMz4kuJGR1ZQPbBNpp7EABJn=Rag8jSrb-2ztcefUf4R7pk4AQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2015 09:31:25.5973
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0862
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2452
Lines: 65

On Mon, Aug 17, 2015 at 02:02:08PM +0800, Baolin Wang wrote:
> On 17 August 2015 at 09:15, Li Jun <b47624@freescale.com> wrote:
> > On Fri, Aug 14, 2015 at 07:04:56PM +0800, Baolin Wang wrote:
> >> On 14 August 2015 at 16:55, Li Jun <b47624@freescale.com> wrote:
> >> > Hi Baolin,
> >> >
> >> > On Fri, Aug 14, 2015 at 05:47:43PM +0800, Baolin Wang wrote:
> >> >> Currently the Linux kernel does not provide any standard integration of this
> >> >> feature that integrates the USB subsystem with the system power regulation
> >> >> provided by PMICs meaning that either vendors must add this in their kernels
> >> >> or USB gadget devices based on Linux (such as mobile phones) may not behave
> >> >> as they should.
> >> >>
> >> >> Providing a standard framework for doing this in the kernel.
> >> >>
> >> >
> >> > Why not add power supply class support into this?
> >> >
> >>
> >> Hi Jun,
> >>
> >> We don't need the power supply class support into the usb charger,
> > I suppose usb charger is also a power supply for the system, we can use power
> > supply class framework for notify mechanism and get/set many attributes(maybe
> > also the current limit), I see those usb charger drivers under ./driver/power/
> > are designed with power supply supported.
> >
> 
> I don't think so. The usb charger is rely on the usb gadget, which is
> not a complete power supply device and it combines the usb and the
> power supply. Thus we make it into usb gadget system. Thanks.
> 
Why it cannot be a complete power supply device? I was thinking this
framework can cover it, I have no doubt on putting this framework
into gadget system, but still can't understand why we don't need
power supply class at all for a usb charger, or you think introduce
power supply into usb gadget is not a right direction from code structure
point view?

Li Jun
> > Li Jun
> >> just introduce the notify mechanism for power to set the current limit
> >> when notifying some events from usb charger. Maybe I misunderstand
> >> your meanings, please describe it detailedly. Thanks for your
> >> comments.
> >>
> >> > Li Jun
> >> >
> >>
> >>
> >>
> >> --
> >> Baolin.wang
> >> Best Regards
> 
> 
> 
> -- 
> Baolin.wang
> Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/