Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbbHQIgE (ORCPT ); Mon, 17 Aug 2015 04:36:04 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:34751 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbHQIgB (ORCPT ); Mon, 17 Aug 2015 04:36:01 -0400 MIME-Version: 1.0 X-Originating-IP: [95.23.111.95] In-Reply-To: References: <1435191645-6022-1-git-send-email-javier.martinez@collabora.co.uk> <1435191645-6022-2-git-send-email-javier.martinez@collabora.co.uk> Date: Mon, 17 Aug 2015 10:36:00 +0200 Message-ID: Subject: Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM From: Javier Martinez Canillas To: Geert Uytterhoeven Cc: Lee Jones , "linux-samsung-soc@vger.kernel.org" , Heiko Stuebner , Paul Gortmaker , Gwendal Grignou , Doug Anderson , "linux-kernel@vger.kernel.org" , Samuel Ortiz , Olof Johansson , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2292 Lines: 59 Hello Geert, Thanks a lot for your feedback. On Mon, Aug 17, 2015 at 9:56 AM, Geert Uytterhoeven wrote: > On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas > wrote: >> The Chrome platform support depends on X86 || ARM because there are >> only Chromebooks using those architectures. But only some drivers >> depend on a given architecture, and the ones that do already have >> a dependency on their specific Kconfig symbol entries. >> >> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST >> but is more future proof to remove the dependency and let the drivers >> be built in all architectures if possible to have more build coverage. >> >> Signed-off-by: Javier Martinez Canillas > > NAKed-by: Geert Uytterhoeven > > The proper way to have more build coverage is to extend the dependencies > with "|| COMPILE_TEST". > Ok, I mentioned that as the other option but was not sure which one was more suitable since CHROME_PLATFORMS is a category and the individual drivers already depend on a given arch. But I will make it depends on X86 || ARM again plus || COMPILE_TEST and in the future if there is a Chromebook on !X86 and !ARM, that new arch can be added to the or logic. > Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a > Kconfig warning on !X86 and !ARM. > > Mixing "select" and "depends" (all other ChromeOS stuff depends on the > symbol) is bad practice, as it may lead to circular Kconfig dependencies. > Yes, I think this is the real issue. I added the select instead of a depends to avoid breaking git bisection when moving the cros_ec com helpers out of MFD since some platforms use MFD_CROS_EC but don't enable CHROME_PLATFORMS on their defconfigs. But I'll change the select to depends instead and include the defconfig changes as a dependency in the series to avoid breaking git bisection. > Gr{oetje,eeting}s, > > Geert > > -- Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/