Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbbHQIkL (ORCPT ); Mon, 17 Aug 2015 04:40:11 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:36275 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbbHQIkJ (ORCPT ); Mon, 17 Aug 2015 04:40:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1438346937-9020-1-git-send-email-rabin@rab.in> Date: Mon, 17 Aug 2015 10:40:08 +0200 X-Google-Sender-Auth: DxA9Ic1oO0GyePvXrDaTaBAh6GE Message-ID: Subject: Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks From: Geert Uytterhoeven To: Linus Walleij Cc: Rabin Vincent , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 36 On Mon, Aug 3, 2015 at 10:53 AM, Linus Walleij wrote: > On Fri, Jul 31, 2015 at 2:48 PM, Rabin Vincent wrote: > >> If the driver has specified its own irq_{request/release}_resources() >> functions, don't override them. The gpio-etraxfs driver will use this. >> >> Signed-off-by: Rabin Vincent > > Perfectly reasonable given the usecase in patch 2/2. Patch applied. So for drivers currently using GPIOLIB_IRQCHIP the calbacks were always overridden, even if they supplied their own? Hence after this change, that's no longer the case, and pinctrl-at91.c will use its own, which are identical to the generic ones, modulo the bug fix in 5b76e79c77264899 ("gpiolib: irqchip: prevent driver unloading if gpio is used as irq only"). Oops... I already wrote an untested patch to convert pinctrl-at91 to the generic ones, shall I send that right away? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/