Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbbHQJBk (ORCPT ); Mon, 17 Aug 2015 05:01:40 -0400 Received: from foss.arm.com ([217.140.101.70]:44631 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbbHQJBi (ORCPT ); Mon, 17 Aug 2015 05:01:38 -0400 Date: Mon, 17 Aug 2015 10:01:32 +0100 From: Will Deacon To: Bjorn Helgaas Cc: Marc Zyngier , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "suravee.suthikulpanit@amd.com" , Lorenzo Pieralisi , "grant.likely@linaro.org" , Rob Herring , "agraf@suse.de" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v2 2/4] PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property Message-ID: <20150817090132.GC1688@arm.com> References: <1439569159-10051-1-git-send-email-marc.zyngier@arm.com> <1439569159-10051-3-git-send-email-marc.zyngier@arm.com> <20150814164051.GF26431@google.com> <20150814164324.GC22809@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 29 On Fri, Aug 14, 2015 at 09:26:21PM +0100, Bjorn Helgaas wrote: > On Fri, Aug 14, 2015 at 11:43 AM, Will Deacon wrote: > > On Fri, Aug 14, 2015 at 05:40:51PM +0100, Bjorn Helgaas wrote: > >> Do we need support for pci-probe-only in pci-host-generic at all? > >> You're removing the use in amd-overdrive.dts, and there are no other > >> DTs in the kernel tree that mention it. > >> > >> If we can live without it, that would be nice. It seems like a relic from > >> days when we couldn't reliably assign resources. (I'm not saying we can do > >> that reliably even today, but I'd rather make it reliable than turn it > >> off.) > > > > Kvmtool certainly uses it (and generates its own DT, hence why you don't > > see it in mainline). Not sure about qemu, though. > > Do you know why kvmtool wants probe-only? Would something break if we > didn't support probe-only? I guess we'd be looking for a case where > Linux assigns resources and that assignment doesn't work with kvmtool? It's basically because the BARs aren't writable other than to find the region size. It could fixed with a bit of pain, but it doesn't help older kvmtools that do work with mainline today. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/