Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687AbbHQKeN (ORCPT ); Mon, 17 Aug 2015 06:34:13 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34566 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbbHQKeK (ORCPT ); Mon, 17 Aug 2015 06:34:10 -0400 MIME-Version: 1.0 In-Reply-To: <55D1B5A1.3050209@samsung.com> References: <3018549.c8iX1Dbrhm@diego> <55D1B5A1.3050209@samsung.com> Date: Mon, 17 Aug 2015 12:34:09 +0200 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled From: Ulf Hansson To: Jaehoon Chung Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Seungwon Jeon , linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 27 [...] >>> - mmc->max_seg_size = mmc->max_req_size; >>> -#endif /* CONFIG_MMC_DW_IDMAC */ >>> + if (host->use_dma) { >>> + mmc->max_segs = host->ring_size; >> >> I expect this may cause a compiler error since host->ring_size is only >> available in the struct dw_mci *host when CONFIG_MMC_DW_IDMAC is set. >> >> I have already pulled in this patch from Jaehoon's pull request. >> Perhaps I should only amend the patch and change the host->ring_size >> to be always available no matter if CONFIG_MMC_DW_IDMAC is set or not? > > Sorry for this. if you can, i think good that CONFIG_MMC_DW_IDMAC is removed at struct dw_mci. > Could you amend it? > If you want to get patch, i will send patch at now. No worries, I amend the patch myself. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/