Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754816AbbHQKfX (ORCPT ); Mon, 17 Aug 2015 06:35:23 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33612 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbHQKfV (ORCPT ); Mon, 17 Aug 2015 06:35:21 -0400 MIME-Version: 1.0 In-Reply-To: References: <1439296994-28480-1-git-send-email-geert+renesas@glider.be> Date: Mon, 17 Aug 2015 12:35:20 +0200 X-Google-Sender-Auth: R_c79Fq5VJ8llOcZvn2LxSEmrDo Message-ID: Subject: Re: [PATCH] PCI: PCI_RCAR_GEN2 and PCI_RCAR_GEN2_PCIE should depend on ARM From: Geert Uytterhoeven To: Phil Edworthy Cc: Geert Uytterhoeven , Bjorn Helgaas , Simon Horman , Valentine Barshak , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1682 Lines: 44 Hi Phil, On Mon, Aug 17, 2015 at 12:23 PM, Phil Edworthy wrote: > On 11 August 2015 13:43, Geert wrote: >> On arm64/shmobile: >> >> drivers/pci/host/pci-rcar-gen2.c: In function 'rcar_pci_cfg_base': >> drivers/pci/host/pci-rcar-gen2.c:112:34: error: dereferencing pointer to >> incomplete type >> struct rcar_pci_priv *priv = sys->private_data; >> ^ >> >> and >> >> drivers/pci/host/pcie-rcar.c:138:52: warning: 'struct pci_sys_data' declared >> inside parameter list >> static inline struct rcar_pcie *sys_to_pcie(struct pci_sys_data *sys) >> ^ >> >> pci_sys_data exists on ARM only, hence these drivers should depend on >> ARM unconditionally. > > Since these drivers should also be used for R-Car Gen3, I assume someone will > have to fix the problem in the same way the designware pci driver is being modified. > Please see http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/353421.html Yes, that would be the correct long-term solution. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/