Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754909AbbHQKhO (ORCPT ); Mon, 17 Aug 2015 06:37:14 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41623 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbbHQKhN (ORCPT ); Mon, 17 Aug 2015 06:37:13 -0400 From: Heiko Stuebner To: Ulf Hansson Cc: Jaehoon Chung , Seungwon Jeon , linux-mmc , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled Date: Mon, 17 Aug 2015 12:37:03 +0200 Message-ID: <1624956.5P1fMUiods@phil> User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <3018549.c8iX1Dbrhm@diego> <55D1B5A1.3050209@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 30 Am Montag, 17. August 2015, 12:34:09 schrieb Ulf Hansson: > [...] > > >>> - mmc->max_seg_size = mmc->max_req_size; > >>> -#endif /* CONFIG_MMC_DW_IDMAC */ > >>> + if (host->use_dma) { > >>> + mmc->max_segs = host->ring_size; > >> > >> I expect this may cause a compiler error since host->ring_size is only > >> available in the struct dw_mci *host when CONFIG_MMC_DW_IDMAC is set. > >> > >> I have already pulled in this patch from Jaehoon's pull request. > >> Perhaps I should only amend the patch and change the host->ring_size > >> to be always available no matter if CONFIG_MMC_DW_IDMAC is set or not? > > > > Sorry for this. if you can, i think good that CONFIG_MMC_DW_IDMAC is > > removed at struct dw_mci. Could you amend it? > > If you want to get patch, i will send patch at now. > > No worries, I amend the patch myself. thanks and sorry for missing that bit. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/