Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217AbbHQMtt (ORCPT ); Mon, 17 Aug 2015 08:49:49 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:36090 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbHQMtr (ORCPT ); Mon, 17 Aug 2015 08:49:47 -0400 MIME-Version: 1.0 In-Reply-To: <55D1D786.2010407@cogentembedded.com> References: <1439246562-17515-1-git-send-email-daniel.baluta@intel.com> <1439246562-17515-5-git-send-email-daniel.baluta@intel.com> <55D1D786.2010407@cogentembedded.com> Date: Mon, 17 Aug 2015 15:49:45 +0300 X-Google-Sender-Auth: gVq7bpjp2a42SmJerCcO3ftu6N8 Message-ID: Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger From: Daniel Baluta To: Vladimir Barinov Cc: Daniel Baluta , Jonathan Cameron , Joel Becker , "linux-iio@vger.kernel.org" , linux-fsdevel@vger.kernel.org, Lars-Peter Clausen , Hartmut Knaack , Linux Kernel Mailing List , "octavian.purdila@intel.com" , Paul Bolle , patrick.porlan@intel.com, Adriana Reus , constantin.musca@intel.com, marten@intuitiveaerial.com, Cristina Georgiana Opriceana , Peter Meerwald , hch@lst.de, viro@zeniv.linux.org.uk, Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 23 On Mon, Aug 17, 2015 at 3:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to sampling_frequency will hrtimer_cancel > and writing any valid frequency will hrtimer_start. Thanks a lot Vladimir for looking at this. I will try to address your comments this week. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/