Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755453AbbHQNRF (ORCPT ); Mon, 17 Aug 2015 09:17:05 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33426 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754802AbbHQNRC (ORCPT ); Mon, 17 Aug 2015 09:17:02 -0400 Date: Mon, 17 Aug 2015 14:16:58 +0100 From: Matt Fleming To: Kanaka Juvva Cc: kanaka.d.juvva@intel.com, glenn.p.williamson@intel.com, matt.fleming@intel.com, will.auld@intel.com, andi@firstfloor.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, tj@kernel.org, x86@kernel.org, mingo@redhat.com, hpa@zytor.com, vikas.shivappa@intel.com Subject: Re: [PATCH v3 2/2] perf,x86: skip intel_cqm_stable if CMT is not present in a CPU model Message-ID: <20150817131658.GC3233@codeblueprint.co.uk> References: <1439019379-10025-1-git-send-email-kanaka.d.juvva@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439019379-10025-1-git-send-email-kanaka.d.juvva@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 21 On Sat, 08 Aug, at 12:36:19AM, Kanaka Juvva wrote: > CMT and MBM are complementary technologies. One technology doesn't > imply the other technology. If CMT is not present in your CPU model > intel_cqm_stable() won't be called when computing a free RMID. This > is because, LLC_OCCUPANCY reading in this case doesn't apply and > shouldn't be used a criteria for freeing or picking an RMID. > > Signed-off-by: Kanaka Juvva > --- > arch/x86/kernel/cpu/perf_event_intel_cqm.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Shouldn't this patch be the first one in the series? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/