Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbbHQNZ7 (ORCPT ); Mon, 17 Aug 2015 09:25:59 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:51844 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755099AbbHQNZ5 (ORCPT ); Mon, 17 Aug 2015 09:25:57 -0400 X-Listener-Flag: 11101 Message-ID: <1439817953.3414.4.camel@mtksdaap41> Subject: Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume From: Yingjoe Chen To: Daniel Kurtz CC: maoguang meng , Linus Walleij , Matthias Brugger , Hongzhou Yang , , "linux-arm-kernel@lists.infradead.org" , , "linux-kernel@vger.kernel.org" Date: Mon, 17 Aug 2015 21:25:53 +0800 In-Reply-To: References: <1439541486-22203-1-git-send-email-maoguang.meng@mediatek.com> <1439797974.22004.2.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3791 Lines: 113 On Mon, 2015-08-17 at 17:09 +0800, Daniel Kurtz wrote: > On Mon, Aug 17, 2015 at 3:52 PM, Yingjoe Chen wrote: > > On Fri, 2015-08-14 at 16:38 +0800, maoguang.meng@mediatek.com wrote: > >> From: Maoguang Meng > >> > >> This patch implement irq_set_wake to get who is wakeup source and > >> setup on suspend resume. > >> > >> Signed-off-by: Maoguang Meng > >> > >> --- > >> changes since v3: > >> -add a comment in mtk_eint_chip_read_mask. > >> -delete ALIGN when allocate eint_offsets.ports. > >> -fix unrelated change. > >> > >> changes since v2: > >> -modify irq_wake to handle irq wakeup source. > >> -allocate two buffers separately. > >> -fix some codestyle. > >> > >> Changes since v1: > >> -implement irq_wake handler. > >> --- > >> > >> drivers/pinctrl/mediatek/pinctrl-mt8173.c | 1 + > >> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 91 ++++++++++++++++++++++++++- > >> drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 4 ++ > >> 3 files changed, 95 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8173.c b/drivers/pinctrl/mediatek/pinctrl-mt8173.c > >> index d0c811d..ad27184 100644 > >> --- a/drivers/pinctrl/mediatek/pinctrl-mt8173.c > >> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8173.c > >> @@ -385,6 +385,7 @@ static struct platform_driver mtk_pinctrl_driver = { > >> .driver = { > >> .name = "mediatek-mt8173-pinctrl", > >> .of_match_table = mt8173_pctrl_match, > >> + .pm = &mtk_eint_pm_ops, > >> }, > >> }; > >> > >> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > >> index ad1ea16..fe34ce9 100644 > >> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > >> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > >> @@ -33,6 +33,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> > >> #include "../core.h" > >> @@ -1062,6 +1063,77 @@ static int mtk_eint_set_type(struct irq_data *d, > >> return 0; > >> } > >> > >> +static int mtk_eint_irq_set_wake(struct irq_data *d, unsigned int on) > >> +{ > >> + struct mtk_pinctrl *pctl = irq_data_get_irq_chip_data(d); > >> + int shift = d->hwirq & 0x1f; > >> + int reg = d->hwirq >> 5; > >> + > >> + if (on) > >> + pctl->wake_mask[reg] |= BIT(shift); > >> + else > >> + pctl->wake_mask[reg] &= ~BIT(shift); > >> + > >> + return 0; > >> +} > > > > Hi Maoguang, > > > > You changed from set_bit/clear_bit to this, but didn't add any locking. > > Since this is basic read/modify/write, is it OK to do it without > > locking? > > I believe calling .irq_set_wake() concurrently with itself is > protected by irq_get_desc_buslock(): > > int irq_set_irq_wake(unsigned int irq, unsigned int on) > { > unsigned long flags; > struct irq_desc *desc = irq_get_desc_buslock(irq, &flags, > IRQ_GET_DESC_CHECK_GLOBAL); > int ret = 0; > ... > ret = set_irq_wake_real(irq, on); > ... > irq_put_desc_busunlock(desc, flags); > return ret; > } Hi Dan, You are right, irq_get_desc_buslock will acquire desc lock even when irq_chip didn't provide irq_bus_lock callback. So this should be OK. Sorry for the noise. For this patch: Acked-by: Yingjoe Chen Joe.C -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/