Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755103AbbHQN20 (ORCPT ); Mon, 17 Aug 2015 09:28:26 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:36682 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbbHQN2Y (ORCPT ); Mon, 17 Aug 2015 09:28:24 -0400 MIME-Version: 1.0 In-Reply-To: <1439816682-9781-1-git-send-email-jthumshirn@suse.de> References: <1439816682-9781-1-git-send-email-jthumshirn@suse.de> Date: Mon, 17 Aug 2015 15:28:22 +0200 Message-ID: Subject: Re: [PATCH] pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY From: Jack Wang To: Johannes Thumshirn Cc: lindar_liu , "James E.J. Bottomley" , "pmchba@pmcs.com" , "linux-scsi@vger.kernel.org" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 48 2015-08-17 15:04 GMT+02:00 Johannes Thumshirn : > In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY > ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a > fallthrough to the default handler of the switch statement overriding ts->stat > to SAS_DEV_NO_RESPONSE. > > Signed-off-by: Johannes Thumshirn Thanks, please feel free to add: Acked-by: Jack Wang > --- > drivers/scsi/pm8001/pm8001_hwi.c | 1 + > drivers/scsi/pm8001/pm80xx_hwi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c > index 96dcc09..d0feec5 100644 > --- a/drivers/scsi/pm8001/pm8001_hwi.c > +++ b/drivers/scsi/pm8001/pm8001_hwi.c > @@ -2642,6 +2642,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) > ts->resp = SAS_TASK_COMPLETE; > ts->stat = SAS_OPEN_REJECT; > ts->open_rej_reason = SAS_OREJ_RSVD_RETRY; > + break; > default: > PM8001_IO_DBG(pm8001_ha, > pm8001_printk("Unknown status 0x%x\n", status)); > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c > index 05cce46..18d4ac4 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -2314,6 +2314,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) > ts->resp = SAS_TASK_COMPLETE; > ts->stat = SAS_OPEN_REJECT; > ts->open_rej_reason = SAS_OREJ_RSVD_RETRY; > + break; > default: > PM8001_IO_DBG(pm8001_ha, > pm8001_printk("Unknown status 0x%x\n", status)); > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/