Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755423AbbHQNy4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Aug 2015 09:54:56 -0400
Received: from imap.thunk.org ([74.207.234.97]:33931 "EHLO imap.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751475AbbHQNyx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Aug 2015 09:54:53 -0400
Date: Mon, 17 Aug 2015 09:54:50 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Navin P <navinp1912@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Why is SECTOR_SIZE = 512 inside kernel ?
Message-ID: <20150817135450.GB27202@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
	Navin P <navinp1912@gmail.com>, linux-kernel@vger.kernel.org
References: <CAA=4086O2qJT53wh9Qq8K5-8aRxtHrf5Ybnjrw39Vp8L3PrVqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA=4086O2qJT53wh9Qq8K5-8aRxtHrf5Ybnjrw39Vp8L3PrVqQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1832
Lines: 43

On Mon, Aug 17, 2015 at 06:23:04PM +0530, Navin P wrote:
> 
>  Why is SECTOR_SIZE 512 ?
> 
> http://lxr.free-electrons.com/source/include/linux/ide.h#L118
> 
> http://lxr.free-electrons.com/source/include/linux/device-mapper.h#L548
> 
> 548 #define SECTOR_SHIFT 9
> 
> I was looking at disks with hw_sector_size . Most of them i looked at
> had 512 bytes except for one which had 4096 (virtual disk). The one
> with AF format ie has logical sector size as 512 and hw_sector_size as
> 512 . So it is fine for my calculation from /proc/diskstats.
> 
> But the one with 4096 logical and 4096 physical i multiply
> hw_sector_size with the sectors read and written but that is wrong
> since the kernel always defines sectors in terms of 512.
> 
> Is it going to change or is it  cast in stone ?

It's cast in stone.  There are too many places all over the kernel,
especially in a huge number of file systems, which assume that the
sector size is 512 bytes.  So above the block layer, the sector size
is always going to be 512.

This is actually *better* for user space programs using
/proc/diskstats, since they don't need to know whether a particular
underlying hardware is using 512, 4k, (or if the HDD manufacturers
fantasies become true 32k or 64k) sector sizes.

For similar reason, st_blocks in struct size is always in units of 512
bytes.  We don't want to force userspace to have to figure out whether
the underlying file system is using 1k, 2k, or 4k.  For that reason
the units of st_blocks is always going to be 512 bytes, and this is
hard-coded in the POSIX standard.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/