Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755714AbbHQOj6 (ORCPT ); Mon, 17 Aug 2015 10:39:58 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:34341 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbbHQOj5 convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2015 10:39:57 -0400 MIME-Version: 1.0 In-Reply-To: <20150817090828.GB5558@mwanda> References: <641be2615e97db253a306c766a48c2afccf338d7.1439702894.git.raphael.beamonte@gmail.com> <20150817090828.GB5558@mwanda> From: =?UTF-8?Q?Rapha=C3=ABl_Beamonte?= Date: Mon, 17 Aug 2015 10:39:37 -0400 X-Google-Sender-Auth: uSSr2Aa3XcQ5J7xDjs1DaJ92uQY Message-ID: Subject: Re: [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements To: Dan Carpenter Cc: Johnny Kim , Rachel Kim , Dean Lee , Chris Park , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 15 2015-08-17 5:08 GMT-04:00 Dan Carpenter : > Pull it in one indent level... But actually this macro has a return in > the middle of it, so it just introduces bugs all over the place like > eating cookies in bed. We should just delete it instead. You're right! I'll clean those macro up and send a new set of patches to replace this one. Thanks for the feedback! Raphaël -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/