Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755582AbbHQPko (ORCPT ); Mon, 17 Aug 2015 11:40:44 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:32939 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbbHQPkm (ORCPT ); Mon, 17 Aug 2015 11:40:42 -0400 Message-ID: <55D2004D.9010401@linaro.org> Date: Mon, 17 Aug 2015 17:39:57 +0200 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Alex Williamson CC: eric.auger@st.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, feng.wu@intel.com, linux-kernel@vger.kernel.org, patches@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH v3 05/10] VFIO: platform: add vfio_platform_is_active References: <1439212864-12954-1-git-send-email-eric.auger@linaro.org> <1439212864-12954-6-git-send-email-eric.auger@linaro.org> <1439405805.4023.529.camel@redhat.com> In-Reply-To: <1439405805.4023.529.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 62 On 08/12/2015 08:56 PM, Alex Williamson wrote: > On Mon, 2015-08-10 at 15:20 +0200, Eric Auger wrote: >> This function returns whether the IRQ is active at irqchip level or >> VFIO masked. If either is true, it is considered the IRQ is active. >> Currently there is no way to differentiate userspace masked IRQ from >> automasked IRQ. There might be false detection of activity. However >> it is currently acceptable to have false detection. >> >> Signed-off-by: Eric Auger >> >> --- >> --- >> drivers/vfio/platform/vfio_platform_irq.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c >> index a285384..efaee58 100644 >> --- a/drivers/vfio/platform/vfio_platform_irq.c >> +++ b/drivers/vfio/platform/vfio_platform_irq.c >> @@ -205,6 +205,23 @@ static int vfio_platform_set_automasked(struct vfio_platform_irq *irq, >> return 0; >> } >> >> +static int vfio_platform_is_active(struct vfio_platform_irq *irq) > > vfio_platform_irq_is_active()? OK > >> +{ >> + unsigned long flags; >> + bool active, masked, outstanding; >> + int ret; >> + >> + spin_lock_irqsave(&irq->lock, flags); >> + >> + ret = irq_get_irqchip_state(irq->hwirq, IRQCHIP_STATE_ACTIVE, &active); >> + BUG_ON(ret); > > Why can't we propagate this error to the caller and let them decide? sure Eric > >> + masked = irq->masked; >> + outstanding = active || masked; >> + >> + spin_unlock_irqrestore(&irq->lock, flags); >> + return outstanding; >> +} >> + >> static void vfio_platform_irq_bypass_stop(struct irq_bypass_producer *prod) >> { >> } > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/