Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbbHQQVG (ORCPT ); Mon, 17 Aug 2015 12:21:06 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33683 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbbHQQVD (ORCPT ); Mon, 17 Aug 2015 12:21:03 -0400 MIME-Version: 1.0 In-Reply-To: <1439826777-11489-1-git-send-email-yuriy.kolerov@synopsys.com> References: <1439826777-11489-1-git-send-email-yuriy.kolerov@synopsys.com> Date: Mon, 17 Aug 2015 18:21:01 +0200 X-Google-Sender-Auth: osrTWBUpno4Wbodqxe95VSfLGH4 Message-ID: Subject: Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE From: Geert Uytterhoeven To: Yuriy Kolerov Cc: "linux-kernel@vger.kernel.org" , Linux-Arch , Linux Fbdev development list , Arnd Bergmann , Andrew Morton , Jean-Christophe PLAGNIOL-VILLARD , Tomi Valkeinen , Vineet Gupta , Alexey Brodkin , Anton.Kolesov@synopsys.com, Francois Bedard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 40 On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov wrote: > Architectures which support VGA console must define screen_info > structurture from "uapi/linux/screen_info.h". Otherwise undefined > symbol error occurs. Usually it's defined in "setup.c" for each > architecture. > > If an architecture does not support VGA console (ARC's case) > there are 2 ways: define a dummy instance of screen_info or add > a negative dependency for VGA_CONSOLE in to prevent selecting > this option. > > I've implemented the second way. However the best solution is to > add HAVE_VGA_CONSOLE option for targets which support VGA > console. Then turn off VGA_CONSOLE by default and add dependency > to HAVE_VGA_CONSOLE. But right now it's better to just add a > negative dependency for ARC and then consider how to collaborate > about this issue with maintainers of other architectures. +1 > Signed-off-by: Yuriy Kolerov Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/