Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755994AbbHQQdg (ORCPT ); Mon, 17 Aug 2015 12:33:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:52905 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755430AbbHQQdf (ORCPT ); Mon, 17 Aug 2015 12:33:35 -0400 Message-ID: <55D20CD6.90709@roeck-us.net> Date: Mon, 17 Aug 2015 09:33:26 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Bjorn Andersson , Wim Van Sebroeck CC: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors References: <1439828343-6679-1-git-send-email-bjorn.andersson@sonymobile.com> In-Reply-To: <1439828343-6679-1-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 31 On 08/17/2015 09:19 AM, Bjorn Andersson wrote: > syscon_node_to_regmap() returns a regmap or an ERR_PTR(). > > Signed-off-by: Bjorn Andersson Acked-by: Guenter Roeck > --- > drivers/watchdog/at91rm9200_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c > index 9ba1153465ae..e12a797cb820 100644 > --- a/drivers/watchdog/at91rm9200_wdt.c > +++ b/drivers/watchdog/at91rm9200_wdt.c > @@ -244,7 +244,7 @@ static int at91wdt_probe(struct platform_device *pdev) > } > > regmap_st = syscon_node_to_regmap(parent->of_node); > - if (!regmap_st) > + if (IS_ERR(regmap_st)) > return -ENODEV; > > res = misc_register(&at91wdt_miscdev); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/