Message-ID: <55D20DC9.2060304@freescale.com>
Date: Mon, 17 Aug 2015 09:37:29 -0700
From: York Sun <yorksun@freescale.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Wolfram Sang <wsa@the-dreams.de>
CC: <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        "Peter Korsgaard" <peter.korsgaard@barco.com>
Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg
References: <1434475692-4611-1-git-send-email-yorksun@freescale.com> <20150815202302.GB3463@katana>
In-Reply-To: <20150815202302.GB3463@katana>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2015 16:37:35.8148 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB149
X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB035;2:jDyxBkhY2UHws4+MOAwS9NiWzmLRabnQ9Eoqw0r1igqRTaN9W7LbcipT3yp88bo580x0XVTJKA8/ve9aeEIM3VkYZaJxxVuOMty4Z8j4/RDETOSscqkZSxkwtTFZ4XfNcJ82Ox+nMY1GWG9xwGyGylbXL9rpz2qfxsbek+D3hl4=;3:fbQl/OupvdyvtH3xjpUu9BO7qVxQdf4UyTwWYIX54DmadZCFpCRPYPm67SWuFAjT7GusXSzV1GyWxUtKynJlmsy91+/ZmD8+scamASgMZjEPPOg/uDWUQ11ZT2X2jghT7tvRAUdevtNEhme9PrFkEw==;25:dt28AZ4OfVXF4jaRy9ZhfiuEqfc5xud64/6RgBwAQlYW4puFe6CEYOISVIG3WhzNWDncj9nv1wr7n5rPuXzXf6usDuTOGNMOk3KV0joYTX+UrdGk0tTyMsXJkQGAh8Gsk4FGec6kq97sESPNtA1zv4j1Pkvl0Mt9Dm0kLKIWstnlVIMWW7fGwvB/lSkqZ4UvKji/WHufnj1HKIaMrsl/ivioeZ8p16MubOQBol4ibPi/DFD3c6OZDeJvtekv6fo8;23:FhhWTHslHKnjq7lctjrv2B1Wof5VIZ6CtnPhwIfPST0MqknmgMwaGD53i2BkbQrzYclpanCsfCW295sqh19iqMxezF19fHpy1ahpmSHR7ImuBCn2usC51atQ9TyYucaE8+XhFYhpMb6smeEf0dn8xrLyiPlirnS4qNatRMvZTIszCAwZrF8vtz1Inne16+oL
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1791
Lines: 54


On 08/15/2015 01:23 PM, Wolfram Sang wrote:
> On Tue, Jun 16, 2015 at 10:28:12AM -0700, York Sun wrote:
>> Based on i2c-mux-gpio driver, similarly the register based mux
>> switch from one bus to another by setting a single register.
>> The register can be on PCIe bus, local bus, or any memory-mapped
>> address.
>>
>> Signed-off-by: York Sun <yorksun@freescale.com>
>> CC: Wolfram Sang <wsa@the-dreams.de>
>> CC: Peter Korsgaard <peter.korsgaard@barco.com>
> 
> Mostly good.
> 
>> +static int i2c_mux_reg_probe(struct platform_device *pdev)
>> +{
>> +	struct regmux *mux;
>> +	struct i2c_adapter *parent;
>> +	struct resource *res;
>> +	int (*deselect)(struct i2c_adapter *, void *, u32);
>> +	unsigned int initial_state, class;
> 
> gcc says:
> 
> drivers/i2c/muxes/i2c-mux-reg.c:182:15: warning: variable 'initial_state' set but not used [-Wunused-but-set-variable]
> 
> It seens you prepared for setting the initial state but don't do the
> actual set?

Thanks for catching this. I set the initial state variable but used another
variable when it is actually used. Kernel Makefile disables
unused-but-set-variable by default. How did you enable this warning without
being flooded by the warnings? (I tried W=1)

> 
>> +static struct platform_driver i2c_mux_reg_driver = {
>> +	.probe	= i2c_mux_reg_probe,
>> +	.remove	= i2c_mux_reg_remove,
>> +	.driver	= {
>> +		.owner	= THIS_MODULE,
> 
> coccicheck says:
> 
> drivers/i2c/muxes/i2c-mux-reg.c:288:3-8: No need to set .owner here. The core will do it.

Will drop it in next version.

York
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/