Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbbHQR1j (ORCPT ); Mon, 17 Aug 2015 13:27:39 -0400 Received: from [216.4.250.2] ([216.4.250.2]:39988 "EHLO p2012.superclick.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750902AbbHQR1i (ORCPT ); Mon, 17 Aug 2015 13:27:38 -0400 Date: Mon, 17 Aug 2015 10:26:23 -0700 From: Mark Brown To: Peter Chen Cc: Baolin Wang , balbi@ti.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, sojka@merica.cz, stern@rowland.harvard.edu, r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, sameo@linux.intel.com, lee.jones@linaro.org, patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management Message-ID: <20150817172623.GO10748@sirena.org.uk> References: <20150817010707.GC1864@shlinux2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NbUNL4d9A9kY58qh" Content-Disposition: inline In-Reply-To: <20150817010707.GC1864@shlinux2> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1713 Lines: 53 --NbUNL4d9A9kY58qh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 17, 2015 at 09:07:08AM +0800, Peter Chen wrote: > On Fri, Aug 14, 2015 at 05:47:46PM +0800, Baolin Wang wrote: > > + 1500, > > + 1800, > > + 550, > > +}; > Why 550 is the last, but not 1800? You'd have to ask the hardware engineers who designed the chip. I suspect it's because 550 was added at a late stage in the design process but I'm basically just guessing there. > > *********************************************************************/ > > @@ -606,8 +646,31 @@ static int wm831x_power_probe(struct platform_device *pdev) > > } > > } > > + if (wm831x_pdata && wm831x_pdata->usb_gadget) { > Where the wm831x_pdata->usb_gadget is initialized? It's platform data, it will be initialised by whatever registers the platform data. --NbUNL4d9A9kY58qh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV0hk+AAoJECTWi3JdVIfQ+UsH+wbg5YAcmiwGvgK5ha7iBYv3 X/tf8J+VEfeEz/MPEzgtFWpTAjOYL6ZrIfODxbh9LJvrzdazSUXBokSuywc/SWk3 1JZbKtJwDiv0OS5OziKFnJVf+iMmLVh3rsaUFaga3gU+3yjtSRjw5fCKM5aq1vmd vLQqiaXQS7kYUb2gJbgYb7IwpbklzCjuogVgxmSfkxnySuTICNusAZmR6SZwpLdr y7q9X2MNu3gaTKjO3Lj0ZFvvGOqxv026CAa16cqHWfOjlf4kmQ0oBuaH/HAEfy3U CWJr+uQVEC3nYbu5t1k6aAveFm1p4JqkaDWMjjvOUsGkkopFlQ4rd9dSSywA1fI= =ZWNJ -----END PGP SIGNATURE----- --NbUNL4d9A9kY58qh-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/