Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbHQRbh (ORCPT ); Mon, 17 Aug 2015 13:31:37 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:33511 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbbHQRbf convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2015 13:31:35 -0400 MIME-Version: 1.0 In-Reply-To: <87oai6an6j.fsf@belgarion.home> References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <1439323034-8820-3-git-send-email-robert.jarzmik@free.fr> <20150816213655.GA4585@laptop.cereza> <87oai6an6j.fsf@belgarion.home> Date: Mon, 17 Aug 2015 14:31:34 -0300 Message-ID: Subject: Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config From: Ezequiel Garcia To: Robert Jarzmik Cc: Brian Norris , Ezequiel Garcia , David Woodhouse , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Antoine Tenart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 42 On 16 August 2015 at 19:22, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> On 11 Aug 09:57 PM, Robert Jarzmik wrote: >>> The cases of READID detection are broken on pxa3xx. The reason is that >>> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we >>> always have : >>> - info->use_dma = 0 (regardless of dma support yet) >>> - info->chunk_size = 0 (not yet detected) >>> >>> The READID issued by pxa3xx_nand_scan() will therefore end up in >>> handle_data_pio(), and do_bytes will be 0, leading to not reading the >>> nand id, and blocking detection. >>> >>> This doesn't happen if "keep_config" is used, which is probably the most >>> tested case. >>> >>> Signed-off-by: Robert Jarzmik >>> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O >>> support") >> >> To be fair, Antoine submitted this a while ago: >> >> http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html >> >> Not sure which one takes precedence in such a case (and yours >> has a proper Fixes tag). > His has precedence. How is it that a fix patch is not yet merge since April ? > Is it because it's part of a still in review serie ? > Exactly. And because I thought it was needed for Berlin support, so it wasn't a regression. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/