Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751102AbbHQRmh (ORCPT ); Mon, 17 Aug 2015 13:42:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51991 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbHQRmf (ORCPT ); Mon, 17 Aug 2015 13:42:35 -0400 Date: Mon, 17 Aug 2015 20:42:41 +0300 From: Dan Carpenter To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte Cc: Johnny Kim , Rachel Kim , Dean Lee , Chris Park , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER() Message-ID: <20150817174241.GD5610@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 21 On Mon, Aug 17, 2015 at 12:08:34PM -0400, Rapha?l Beamonte wrote: > It was just a wrapper around kfree(), so call that instead. > > Signed-off-by: Rapha?l Beamonte > --- > + kfree(exported_g_tx_buf); > + exported_g_tx_buf = NULL; No need to add these new NULL assignments. The module is unloading so no one cat re-use these pointers. Also as a process rule, you should write down any behaviour changes in the changelog and why you think they are needed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/