Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbbHQSaU (ORCPT ); Mon, 17 Aug 2015 14:30:20 -0400 Received: from gabe.freedesktop.org ([131.252.210.177]:35476 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbHQSaS (ORCPT ); Mon, 17 Aug 2015 14:30:18 -0400 From: Eric Anholt To: Stephen Warren , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org Subject: Re: [PATCH 1/7] drm/vc4: Add devicetree bindings for VC4. In-Reply-To: <55CEC25E.7070303@wwwdotorg.org> References: <1439427380-2436-1-git-send-email-eric@anholt.net> <1439427380-2436-2-git-send-email-eric@anholt.net> <55CEC25E.7070303@wwwdotorg.org> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Aug 2015 11:30:14 -0700 Message-ID: <874mjxwyx5.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2898 Lines: 64 --=-=-= Content-Type: text/plain Stephen Warren writes: > On 08/12/2015 06:56 PM, Eric Anholt wrote: >> Signed-off-by: Eric Anholt > > This one definitely needs a patch description, since someone might not > know what a VC4 is, and "git log" won't show the text from the binding > doc itself. I'd suggest adding the initial paragraph of the binding doc > as the patch description, or more. > >> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt >> +- hvss: List of references to HVS video scalers >> +- encoders: List of references to output encoders (HDMI, SDTV) > > Would it make sense to make all those nodes child node of the vc4 > object. That way, there's no need to have these lists of objects; they > can be automatically built up as the DT is enumerated. I know that e.g. > the NVIDIA Tegra host1x binding works this way, and I think it may have > been inspired by other similar cases. I've looked at tegra, and the component system used by msm appears to be nicer than it. To follow tegra's model, it looks like I need to build this extra bus thing corresponding to host1x that is effectively the drivers/base/component.c code, so that I can get at vc4's structure from the component drivers. > Of course, this is only appropriate if the HW modules really are > logically children of the VC4 HW module. Perhaps they aren't. If they > aren't though, I wonder what this "vc4" module actually represents in HW? It's the subsystem, same as we use a subsystem node for msm, sti, rockchip, imx, and exynos. This appears to be the common model of how the collection of graphics-related components is represented in the DT. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJV0ig3AAoJELXWKTbR/J7on3sQAIuqSQIicKD9Aq1CrHQnT6jT fvP+nTKjD5UDqiOu0SwKh1OLlB9Qvg/uVW9bhbL269FTG6B3VnmMRNVcXQvc3blb 1wnG3Bj59xtc40qH3qLy1mVzqe+2RUOPLTsDRln1QEsX4M0CqusUEHzijPUxSVA9 KoIEz0KUVQDERVFgknwRR7OjrkQQGtph4rvmV7ms5gG4WMEMP4OHEphUJptckI74 9RGQb+EKCRdeYrm5gMFETiRcqrVTxGMVo7t/jjq5SEOsvQd7YEeWgfITs/kTJzda Hj6LUYBQ3p5kHkNPwaLG0W2Jc2GRFGqa5QOlMqUdLtEnsxUb4GwVlrt6fFoN5F34 /XTEF4QIOvmft/Nj/xVz1zIkzolM7zNmLprz3PI71Z3kdbTsuNkHD1+eb/c654a/ c9GHlHApAd2ZLyoGaRql5DaClIsj4w1dZf9IOPT+457AkSItxV10JJ0m6tx1BqRH BM2u5gmbwGXeVRYkktHvJ8OjMCPr7/c7h1moTa9tUV8tbHv/kyXnjHXEMyprz0mo qVxY0CYrBXk0zBKj6BQzKAZOb90k5Mex/1/3T4HcEHQYh800GjLHW0VVtLfOpLq8 L1I3Z43b2jaXutQ2mCPLvG9vxasy399TotO11X0Wfmlg7O6K65Xw2TW1ogh65R8/ YRtj7IUNWUk3VNuNvXBl =pFUQ -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/