Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbbHQTHr (ORCPT ); Mon, 17 Aug 2015 15:07:47 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:52874 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbbHQTHq (ORCPT ); Mon, 17 Aug 2015 15:07:46 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 17 Aug 2015 21:07:44 +0200 X-ME-IP: 92.136.201.37 From: Robert Jarzmik To: Antoine Tenart , Ezequiel Garcia , Brian Norris Cc: David Woodhouse , "linux-mtd\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <1439323034-8820-3-git-send-email-robert.jarzmik@free.fr> <20150816213655.GA4585@laptop.cereza> <87oai6an6j.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 17 Aug 2015 21:03:38 +0200 In-Reply-To: (Ezequiel Garcia's message of "Mon, 17 Aug 2015 14:31:34 -0300") Message-ID: <87k2stagad.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1857 Lines: 48 Ezequiel Garcia writes: > On 16 August 2015 at 19:22, Robert Jarzmik wrote: >> Ezequiel Garcia writes: >> >>> On 11 Aug 09:57 PM, Robert Jarzmik wrote: >>>> The cases of READID detection are broken on pxa3xx. The reason is that >>>> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we >>>> always have : >>>> - info->use_dma = 0 (regardless of dma support yet) >>>> - info->chunk_size = 0 (not yet detected) >>>> >>>> The READID issued by pxa3xx_nand_scan() will therefore end up in >>>> handle_data_pio(), and do_bytes will be 0, leading to not reading the >>>> nand id, and blocking detection. >>>> >>>> This doesn't happen if "keep_config" is used, which is probably the most >>>> tested case. >>>> >>>> Signed-off-by: Robert Jarzmik >>>> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O >>>> support") >>> >>> To be fair, Antoine submitted this a while ago: >>> >>> http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html >>> >>> Not sure which one takes precedence in such a case (and yours >>> has a proper Fixes tag). >> His has precedence. How is it that a fix patch is not yet merge since April ? >> Is it because it's part of a still in review serie ? Antoine, could you resubmit this single patch with this as trailer please : Acked-by: Robert Jarzmik Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O support") This should get in Brian's fixes tree as soon as possible. Thanks. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/