Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbbHQTTv (ORCPT ); Mon, 17 Aug 2015 15:19:51 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:52332 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbbHQTTt (ORCPT ); Mon, 17 Aug 2015 15:19:49 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 17 Aug 2015 21:19:48 +0200 X-ME-IP: 92.136.201.37 From: Robert Jarzmik To: Ezequiel Garcia Cc: Ezequiel Garcia , David Woodhouse , Brian Norris , "linux-mtd\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" , Antoine Tenart Subject: Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts References: <1439396538-13298-1-git-send-email-robert.jarzmik@free.fr> <20150816152924.GA799@laptop.cereza> <87si7iandq.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 17 Aug 2015 21:15:48 +0200 In-Reply-To: (Ezequiel Garcia's message of "Mon, 17 Aug 2015 16:09:04 -0300") Message-ID: <87d1ylafq3.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 26 Ezequiel Garcia writes: > In other words, it seems that we must wake the IRQ thread handler > _before_ we clear RDDREQ, not after. > > So unless I'm completely off, the current patch is right, and a comment > would be helpful. Ok Ezequiel, I'll wait for your Tested-by, and respin with something like : /* Clear all status bit before issuing the next command, which can and * will alter the status bits and will deserve a new interrupt on its * own. */ > OK, I'll see about testing your four patches on some Armada 370/XP. Yeah, that would be good. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/